Skip to content

deps: follow go-sctp main to 614ae64 - #79

Merged
gomaja merged 1 commit into
mainfrom
deps/go-sctp-614ae64
Oct 10, 2026
Merged

gomaja merged 1 commit into
mainfrom
deps/go-sctp-614ae64

Conversation

@gomaja

@gomaja gomaja commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

go-sctp has five changes since our pin da2f7fb. All are tests, CI or documentation:

  • the ResolveAddrContext tests are now deterministic;
  • the socket suite runs against a big-endian s390x kernel;
  • a descriptor-handling test is fixed;
  • CI pins staticcheck to a version that reads Go 1.27.2 export data;
  • codeql-action is bumped.

In the library, name resolution now goes through an internal function that tests can replace, with behaviour unchanged. The docs now state that Dial's context does not interrupt Config.Control, and that an interrupted dial is released with an ABORT by default (RFC 9260 §9.1).

Validation

Under Go 1.27.2:

  • go build ./..., go test ./... -count=1, go test -race ./diam/... -count=1 and go vet ./... pass;
  • staticcheck at the go-tools commit that reads Go 1.27.2 export data and golangci-lint run ./... report no issues, and gofmt -l . is empty;
  • the examples/middleware build, vet and test pass, and govulncheck reports no vulnerabilities;
  • the SCTP tests ran with no skips, including the SCTP hostname-resolution cancellation tests.

Summary by cubic

Updates the go-sctp dependency from da2f7fb to 614ae64. The new pin brings test, CI, and documentation fixes, plus a refactor of name resolution that preserves behavior. The docs now clarify that Dial's context does not interrupt Config.Control and that interrupted dials are released with an ABORT by default.

Written for commit b0d4b4a. Summary will update on new commits.

View guided diff Turn on auto-fix

The five go-sctp changes since da2f7fb are tests, CI and documentation:
deterministic ResolveAddrContext tests, a big-endian s390x kernel run,
a descriptor test fix, and a staticcheck pin that reads Go 1.27.2. In
the library, name resolution now goes through an internal function
tests can replace (behaviour unchanged), and the docs state that Dial's
context does not interrupt Config.Control and that an interrupted dial
is released with an ABORT by default (RFC 9260 §9.1).
Copilot AI balanced review requested due to automatic review settings October 10, 2026 09:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T09:30:09.889378Z b0d4b4a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5605bfbb-a166-48d9-90ce-ef7bf0545859

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gomaja

gomaja commented Oct 10, 2026

Copy link
Copy Markdown
Owner Author

The lint failure is not from this change: staticcheck 2026.2.1 cannot read the export data of Go 1.27.2, the stable release CI now installs, so it stopped before analysing any package. Under Go 1.27.2, a staticcheck built from go-tools master (452d5bb, the commit go-sctp's CI now pins) and golangci-lint both report no issues on this branch. The workflow pin is updated in a separate change.

@gomaja
gomaja merged commit f24888d into main Oct 10, 2026
15 of 16 checks passed
@gomaja
gomaja deleted the deps/go-sctp-614ae64 branch October 10, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants