Repository navigation
Preserve literal multiline text through visual editor saves - #310
Closed
concordia-claw wants to merge 1 commit into
Closed
concordia-claw wants to merge 1 commit into
concordia-claw wants to merge 1 commit into
Conversation
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #309.
Summary
.value, avoiding quoted-attribute interpolation and single-line newline removal.Independent of #308: this contribution deliberately uses correctly mapped player cards and changes no card identity logic. There are no PR dependencies and no new runtime dependencies.
Verification
SimulationServerand real entities built byminimal.Entitywith Constant Instructions. Each case checks initial render, actual Save, SSE repaint, reload, and a no-op Save; only the selected field changes. Quotes, multiline LF text, blank lines, angle brackets, ampersands, Unicode, empty strings, surrounding whitespace, and literal closing textarea/script text are covered. Read-only state remains uneditable and backend validation rejects it.Simulation.play,Sequential.run_loop, and model methods are guarded against calls: zero simulation steps or model calls.Run the ordinary renderer regressions:
The optional browser suite is skipped without Playwright. To run it against the current-main merge result:
Branch ancestry
This fork cannot push upstream workflow changes with its existing credential scope. The publication branch therefore contains only this fix above shared ancestor
44904ec; no workflow or credential changes were made. Its predicted merge into upstream9e4173fis exactly tree-identical to the tested current-main commit9c8cb50a2da237286579055b87a7c6619318e4d0(tree75c7b65d0bd569e65d058f145523031f2338423f), and the three-dot PR diff exactly matches the reviewed current-main feature diff. The 8 pure renderer cases also pass on the publication head. The older fork server was never launched.No generated evidence, screenshots, host configuration, live-game changes, or unrelated features are included.
Repository CI
Remote CLA passes.
zizmor-outputfails; its failure log was unavailable to this CLI at the final audit. No workflow files are changed by this PR. This is not an all-green CI claim.