Repository navigation
Consume rejected editor request bodies before responding - #328
Closed
concordia-claw wants to merge 1 commit into
Closed
concordia-claw wants to merge 1 commit into
concordia-claw wants to merge 1 commit into
Conversation
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #327.
Consume the existing framed POST body before the dynamic editor's paused/bound-simulation guards reply. Unread request bytes can cause TCP reset at close, losing the intended JSON error. Keep original HTTP200/application-status semantics and guard precedence over JSON decoding. Rejected requests still cannot mutate or broadcast state.
This is an independent two-file bug fix based on current upstream main9e4173f, not a Bellwether feature stack. No engine/model execution or service/configuration changes.
Verification
Run:
python -m pytest -o addopts='' concordia/utils/simulation_server_test.py -qLimits
This repairs valid Content-Length request completion; it does not redesign framing, streaming limits, legacy status codes, or runtime quiescence. Existing authenticated player/API listeners are not changed. No claim of exhaustive network-stack coverage.