Repository navigation
Remove dead legacy remove_duplicate_dicts helper - #398
Open
ajitashwath wants to merge 1 commit into
Open
ajitashwath wants to merge 1 commit into
ajitashwath wants to merge 1 commit into
Conversation
Superseded by remove_duplicate_values + _make_hashable from the google-deepmind#299 rework. find_data_in_nested_structure no longer calls it, no other callers remain, and its frozenset(d.items()) implementation raises AttributeError on the non-dict values the new path supports.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #299.
find_data_in_nested_structurenow dedups viaremove_duplicate_values+_make_hashable, leavingremove_duplicate_dictswith zero callers repo-wide (verified viagit grepon currentmain). Itsfrozenset(d.items())implementation also crashes on the non-dict values the new path supports, so keeping it invites misuse.Deletion-only change (plus one docstring reword); no behavior change.