fix(sessions): apply afterTimestamp and numRecentEvents together in VertexAiSessionService#1372
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_952662321
branch
from
July 23, 2026 15:00
b4a653e to
429f25d
Compare
…ertexAiSessionService `getSession` gated the server-side `timestamp>=` filter on `numRecentEvents` being absent, so the two `GetSessionConfig` filters could not be combined. Send the `afterTimestamp` filter whenever it is set and still trim to `numRecentEvents` client-side, so both compose. Mirrors the Go port, which already applies both. PiperOrigin-RevId: 952765675
copybara-service
Bot
force-pushed
the
test_952662321
branch
from
July 23, 2026 15:08
429f25d to
24a4588
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(sessions): apply afterTimestamp and numRecentEvents together in VertexAiSessionService
getSessiongated the server-sidetimestamp>=filter onnumRecentEventsbeing absent, so the twoGetSessionConfigfilters could not be combined. Send theafterTimestampfilter whenever it is set and still trim tonumRecentEventsclient-side, so both compose. Mirrors the Go port, which already applies both.