test: add unit tests for ActiveStreamingTool and ReadonlyContext#464
Open
nuthalapativarun wants to merge 2 commits into
Open
test: add unit tests for ActiveStreamingTool and ReadonlyContext#464nuthalapativarun wants to merge 2 commits into
nuthalapativarun wants to merge 2 commits into
Conversation
This was referenced Jun 28, 2026
kalenkevich
reviewed
Jul 1, 2026
| @@ -0,0 +1,117 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2025 Google LLC | |||
| @@ -0,0 +1,51 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2025 Google LLC | |||
Contributor
Author
|
Hi team — following up on PR #464 (unit tests for ActiveStreamingTool and ReadonlyContext, 14 tests). Mergeable. Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two classes in
core/src/agents/have no unit test coverage:ActiveStreamingTool(active_streaming_tool.ts)ReadonlyContext(readonly_context_test.ts)Solution
Add unit tests for both classes:
active_streaming_tool_test.ts— 5 tests covering:taskandstreamareundefined)tasksetstreamsetinstanceof LiveRequestQueuecheck)readonly_context_test.ts— 9 tests covering:InvocationContextmockinvocationId,userId,sessionId,agentName,userContent) delegates correctlyuserContentisundefinedwhen not setstatereturns aStatewrapping the session state valuesstatereturns a newStateinstance on each accessTesting
All 2209 existing tests continue to pass. The 2 pre-existing failures (
database_session_service_test.tstimeout) are unrelated to this change.Checklist