Skip to content

default partition metadata in vmap/scan/pmap#5508

Open
mohsinm-dev wants to merge 1 commit into
google:mainfrom
mohsinm-dev:fix-default-partition-metadata
Open

default partition metadata in vmap/scan/pmap#5508
mohsinm-dev wants to merge 1 commit into
google:mainfrom
mohsinm-dev:fix-default-partition-metadata

Conversation

@mohsinm-dev

@mohsinm-dev mohsinm-dev commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Fixes #5112.

vmap, scan, and pmap now inject {PARTITION_NAME: None} into transform_metadata when the key is absent, so out_sharding metadata stays aligned with array rank after a transform adds an axis.

Previously required the manual workaround:

transform_metadata={nnx.PARTITION_NAME: None}

Changes:

  • _default_transform_metadata helper in iteration.py
  • negative axis normalization in spmd.add_axis
  • regression tests for vmap/scan/pmap default metadata
  • docs updated to remove manual workaround

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nnx.Optimizer doesn't respect extra sharding axis added by nnx.scan/nnx.vmap

1 participant