cache cond/switch branch wrappers to avoid tracing cache misses#5517
Open
mohsinm-dev wants to merge 1 commit into
Open
cache cond/switch branch wrappers to avoid tracing cache misses#5517mohsinm-dev wants to merge 1 commit into
mohsinm-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5512
nnx.condandnnx.switchcreate freshSimpleCondFnwrappers andmerge_inputsclosures on every call. JAX keys its tracing cache on callable identity, so new wrappers cause repeated cache misses even when the underlying branch functions are stable.Cache wrappers in a
WeakKeyDictionarykeyed by the original callable:SimpleCondFnwrappers via_get_simple_cond_fn(graph_updates=Falsepath)merge_inputswrappers cached inline (graph_updates=Truepath)Non-weakly-referenceable callables fall back to fresh wrappers (same behavior as before).