Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

Add CMake build. #396

Open
isaachier wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add CMake build. #396

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ffca0f8
Add CMake build.
isaachier Sep 26, 2017
e925588
Add CMake support for test cases.
isaachier Sep 26, 2017
48cc5b3
Fix headers list.
isaachier Sep 26, 2017
79ba38b
Fix Windows build and gtest usage.
Sep 26, 2017
d93da3d
Fix Windows include directory path.
Sep 26, 2017
748829a
Fix Travis CMake build.
Sep 26, 2017
e46ac84
Change WIN32 to MSVC
isaachier Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ target_include_directories(gumbo PUBLIC
if(WIN32)
Copy link
Copy Markdown

@NikitaFeodonit NikitaFeodonit Mar 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be so:

if(MSVC)

For example, MinGW is GNU compiler with WIN32=true, and it does not need the file 'visualc/include/strings.h'.

Copy link
Copy Markdown
Author

@isaachier isaachier Mar 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thank you.

list(APPEND HEADERS visualc/include/strings.h)
target_include_directories(gumbo PUBLIC
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/visualc>)
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/visualc/include>)
endif()

# Installation (https://github.com/forexample/package-example)
Expand Down