Skip to content
Open
Show file tree
Hide file tree
Changes from 61 commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
a8b2766
wip setting row component
Kimblebee Apr 8, 2026
3e8d8a5
wip more quick setting row components
Kimblebee Apr 9, 2026
75c6f0d
move setting button creation into auxiliary functions
Kimblebee Apr 9, 2026
9ce2206
refactor to quick setting structure WIP
Kimblebee Apr 28, 2026
957c903
spotless
Kimblebee Apr 28, 2026
713462d
Externalize quick settings strings and refactor flash mode logic.
Kimblebee May 7, 2026
73a61d2
rearrange some functions
Kimblebee May 7, 2026
16936f4
update accessibility
Kimblebee May 7, 2026
a2e0400
Add test tags for quick settings buttons and row components.
Kimblebee May 7, 2026
9362ea6
Re-add optional 'More Settings' button to Quick Settings and clean up…
Kimblebee May 8, 2026
a2ab97e
spotless
Kimblebee May 9, 2026
a123ef1
Merge branch 'main' into kim/refactor/quickSettings/button-rows
Kimblebee May 11, 2026
5496148
Clean up unused quick settings resources and enums
Kimblebee May 11, 2026
0ebd3d7
spotless
Kimblebee May 11, 2026
7b10eaa
Merge branch 'main' into kim/refactor/quickSettings/button-rows
Kimblebee May 26, 2026
1a3c0bb
correct flash disabled reason for setting
Kimblebee May 26, 2026
f3e4396
update more settings navigation button
Kimblebee May 26, 2026
28cff6c
delete unused resources and add statement to styleguide to check for …
Kimblebee May 27, 2026
8453206
restrict visibility modifiers
Kimblebee May 27, 2026
b222813
Decouple HDR settings from capture modes
Kimblebee Jun 2, 2026
d35aa64
spotless
Kimblebee Jun 2, 2026
c1d1e30
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee Jun 2, 2026
b2ea948
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee Jun 3, 2026
59c6b8e
address pr comments
Kimblebee Jun 3, 2026
399e6c9
Merge branch 'kim/hdr/decouple-capture-modes' of https://github.com/g…
Kimblebee Jun 5, 2026
a7c65da
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee Jun 8, 2026
54c2650
hdrUiStateAdapterTest visibility modifier
Kimblebee Jun 8, 2026
a0520f5
spotless
Kimblebee Jun 8, 2026
dadb77c
cleanup
Kimblebee Jun 9, 2026
ea35248
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee Jun 9, 2026
4399707
update concurrent camera ui for constraints and add test for HDR sett…
Kimblebee Jun 9, 2026
3b91a8b
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee Jun 11, 2026
4cf67d5
Merge branch 'origin/kim/hdr/decouple-capture-modes' into kim/refacto…
Kimblebee Jun 11, 2026
28bbbac
Support disabled HDR state when current lens doesn't support it but d…
Kimblebee Jun 11, 2026
277d94e
Disable LLB on HDR conflict and vice versa instead of hiding
Kimblebee Jun 11, 2026
35666ef
spotless
Kimblebee Jun 12, 2026
cd4143e
Address code review feedback on Quick Settings and Flash/HDR UI state
Kimblebee Jun 15, 2026
18a3df3
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee Jun 17, 2026
6962be0
clean vestige dynamicrage param.
Kimblebee Jun 17, 2026
4acbf70
Merge branch 'main' of https://github.com/google/jetpack-camera-app i…
Kimblebee Jun 17, 2026
e39d345
Format code with Spotless
Kimblebee Jun 17, 2026
759004f
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee Jun 17, 2026
c1d16a4
update naming conventions for component tags
Kimblebee Jun 19, 2026
c31ec6c
Merge branch 'kim/hdr/decouple-capture-modes' into kim/refactor/quick…
Kimblebee Jun 19, 2026
21f3835
Merge branch 'kim/hdr/decouple-capture-modes' into kim/refactor/quick…
Kimblebee Jun 19, 2026
8b42881
polish Quick Settings state handling and clean up KDocs
Kimblebee Jun 19, 2026
e2cf4d7
spotless
Kimblebee Jun 19, 2026
9986ecd
update comments
Kimblebee Jun 24, 2026
73545ab
Merge branch 'kim/hdr/decouple-capture-modes' into kim/refactor/quick…
Kimblebee Jun 24, 2026
0afe2f8
update hdruistate adapter docs
Kimblebee Jun 26, 2026
9b33f64
refactor(ui): simplify HdrUiState resolution and add concurrent c…
Kimblebee Jun 26, 2026
5b63267
spotless
Kimblebee Jun 26, 2026
332b827
Merge branch 'kim/hdr/decouple-capture-modes' into kim/refactor/quick…
Kimblebee Jun 26, 2026
3f93f5d
refactor(ui): Migrate SettingRow to Slot API for performance
Kimblebee Jun 26, 2026
0105845
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee Jul 6, 2026
e3c1947
Merge branch 'kim/hdr/decouple-capture-modes' into kim/refactor/quick…
Kimblebee Jul 6, 2026
2b4fb10
Merge branch 'main' into kim/refactor/quickSettings/button-rows
Kimblebee Jul 8, 2026
f7cff4e
Optimize FlashModeUiStateAdapter by removing redundant collection all…
Kimblebee Jul 8, 2026
9f0e2af
Add unit test for Flash/HDR conflict happy path with LLB enabled
Kimblebee Jul 8, 2026
64d1e0b
Clean up unused imports, fix formatting, and sync KDocs
Kimblebee Jul 8, 2026
6d5e6b4
Merge branch 'main' into kim/refactor/quickSettings/button-rows
Kimblebee Jul 9, 2026
8d5e463
Merge branch 'main' into kim/refactor/quickSettings/button-rows
Kimblebee Jul 16, 2026
687f0a1
Address PR comments: refactor Quick Settings layouts, decouple HDR st…
Kimblebee Jul 17, 2026
6799783
spotless
Kimblebee Jul 17, 2026
c3e2211
Refactor QuickSettingsController and align HDR constraints
Kimblebee Jul 28, 2026
54dfcf2
Refactor Quick Settings to unified layout and apply code review cleanups
Kimblebee Jul 28, 2026
c682cbc
Refactor QuickSettings row components to use a generic list-based…
Kimblebee Jul 29, 2026
fa32a0c
use connected button shapes
Kimblebee Jul 29, 2026
cb36de9
adjust button dimensions
Kimblebee Jul 29, 2026
b58627f
adjustpreview
Kimblebee Jul 29, 2026
e7f3631
spotless
Kimblebee Jul 29, 2026
41658c0
Merge branch 'main' into kim/refactor/quickSettings/button-rows
Kimblebee Jul 29, 2026
bfd867e
update test behavior and minsdk
Kimblebee Jul 29, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gemini/styleguide.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ When reviewing a pull request, focus on the following key areas:
8. **Resource Management**
* **No Hardcoded Strings:** Forbid hardcoded user-facing strings in composables. All text should be extracted into `strings.xml` to support localization and make updates easier.
* **Prefer Vector Drawables:** For icons and simple graphics, vector drawables (SVGs) should be preferred over raster images (PNGs) to reduce APK size and ensure sharp rendering on all screen densities.
* **Delete Unused Resources:** When refactoring or removing components, ensure that any associated resources (such as strings in `strings.xml` or icons/drawables in the `res/drawable` directory) that are no longer used anywhere in the project are deleted to reduce the final file size and maintain codebase cleanliness.

9. **Readability, Logging, and Documentation**
* **Code Clarity:** Is the code clear, concise, and easy to understand? Are function and variable names descriptive?
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,8 @@ private fun ContentScreen(
quickSettingsController.toggleQuickSettings()
onNavigateToSettings()
},
quickSettingsController = quickSettingsController
quickSettingsController = quickSettingsController,
showMoreSettingsButton = true
)
}
Unit
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,17 @@ const val BTN_QUICK_SETTINGS_FOCUSED_CAPTURE_MODE_VIDEO_ONLY =
"quick_settings_focused_capture_mode_btn_option_video_only"
const val BTN_QUICK_SETTINGS_FOCUSED_CAPTURE_MODE_IMAGE_ONLY =
"quick_settings_focused_capture_mode_btn_option_image_only"

const val BTN_QUICK_SETTINGS_FLASH_OPTION_OFF = "btn_quick_settings_flash_option_off"
const val BTN_QUICK_SETTINGS_FLASH_OPTION_ON = "btn_quick_settings_flash_option_on"
const val BTN_QUICK_SETTINGS_FLASH_OPTION_AUTO = "btn_quick_settings_flash_option_auto"
const val BTN_QUICK_SETTINGS_FLASH_OPTION_LOW_LIGHT_BOOST =
"btn_quick_settings_flash_option_low_light_boost"

const val BTN_QUICK_SETTINGS_HDR_OPTION_ON = "btn_quick_settings_hdr_option_on"
const val BTN_QUICK_SETTINGS_HDR_OPTION_OFF = "btn_quick_settings_hdr_option_off"

const val ROW_QUICK_SETTINGS_CAPTURE_MODE = "row_quick_settings_capture_mode"
const val ROW_QUICK_SETTINGS_HDR = "row_quick_settings_hdr"
const val ROW_QUICK_SETTINGS_ASPECT_RATIO = "row_quick_settings_aspect_ratio"
const val ROW_QUICK_SETTINGS_FLASH = "row_quick_settings_flash"

Large diffs are not rendered by default.

Loading
Loading