-
Notifications
You must be signed in to change notification settings - Fork 66
Refactor Quick Settings UI #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kimblebee
wants to merge
73
commits into
main
Choose a base branch
from
kim/refactor/quickSettings/button-rows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 19 commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
a8b2766
wip setting row component
Kimblebee 3e8d8a5
wip more quick setting row components
Kimblebee 75c6f0d
move setting button creation into auxiliary functions
Kimblebee 9ce2206
refactor to quick setting structure WIP
Kimblebee 957c903
spotless
Kimblebee 713462d
Externalize quick settings strings and refactor flash mode logic.
Kimblebee 73a61d2
rearrange some functions
Kimblebee 16936f4
update accessibility
Kimblebee a2e0400
Add test tags for quick settings buttons and row components.
Kimblebee 9362ea6
Re-add optional 'More Settings' button to Quick Settings and clean up…
Kimblebee a2ab97e
spotless
Kimblebee a123ef1
Merge branch 'main' into kim/refactor/quickSettings/button-rows
Kimblebee 5496148
Clean up unused quick settings resources and enums
Kimblebee 0ebd3d7
spotless
Kimblebee 7b10eaa
Merge branch 'main' into kim/refactor/quickSettings/button-rows
Kimblebee 1a3c0bb
correct flash disabled reason for setting
Kimblebee f3e4396
update more settings navigation button
Kimblebee 28cff6c
delete unused resources and add statement to styleguide to check for …
Kimblebee 8453206
restrict visibility modifiers
Kimblebee b222813
Decouple HDR settings from capture modes
Kimblebee d35aa64
spotless
Kimblebee c1d1e30
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee b2ea948
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee 59c6b8e
address pr comments
Kimblebee 399e6c9
Merge branch 'kim/hdr/decouple-capture-modes' of https://github.com/g…
Kimblebee a7c65da
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee 54c2650
hdrUiStateAdapterTest visibility modifier
Kimblebee a0520f5
spotless
Kimblebee dadb77c
cleanup
Kimblebee ea35248
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee 4399707
update concurrent camera ui for constraints and add test for HDR sett…
Kimblebee 3b91a8b
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee 4cf67d5
Merge branch 'origin/kim/hdr/decouple-capture-modes' into kim/refacto…
Kimblebee 28bbbac
Support disabled HDR state when current lens doesn't support it but d…
Kimblebee 277d94e
Disable LLB on HDR conflict and vice versa instead of hiding
Kimblebee 35666ef
spotless
Kimblebee cd4143e
Address code review feedback on Quick Settings and Flash/HDR UI state
Kimblebee 18a3df3
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee 6962be0
clean vestige dynamicrage param.
Kimblebee 4acbf70
Merge branch 'main' of https://github.com/google/jetpack-camera-app i…
Kimblebee e39d345
Format code with Spotless
Kimblebee 759004f
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee c1d16a4
update naming conventions for component tags
Kimblebee c31ec6c
Merge branch 'kim/hdr/decouple-capture-modes' into kim/refactor/quick…
Kimblebee 21f3835
Merge branch 'kim/hdr/decouple-capture-modes' into kim/refactor/quick…
Kimblebee 8b42881
polish Quick Settings state handling and clean up KDocs
Kimblebee e2cf4d7
spotless
Kimblebee 9986ecd
update comments
Kimblebee 73545ab
Merge branch 'kim/hdr/decouple-capture-modes' into kim/refactor/quick…
Kimblebee 0afe2f8
update hdruistate adapter docs
Kimblebee 9b33f64
refactor(ui): simplify HdrUiState resolution and add concurrent c…
Kimblebee 5b63267
spotless
Kimblebee 332b827
Merge branch 'kim/hdr/decouple-capture-modes' into kim/refactor/quick…
Kimblebee 3f93f5d
refactor(ui): Migrate SettingRow to Slot API for performance
Kimblebee 0105845
Merge branch 'main' into kim/hdr/decouple-capture-modes
Kimblebee e3c1947
Merge branch 'kim/hdr/decouple-capture-modes' into kim/refactor/quick…
Kimblebee 2b4fb10
Merge branch 'main' into kim/refactor/quickSettings/button-rows
Kimblebee f7cff4e
Optimize FlashModeUiStateAdapter by removing redundant collection all…
Kimblebee 9f0e2af
Add unit test for Flash/HDR conflict happy path with LLB enabled
Kimblebee 64d1e0b
Clean up unused imports, fix formatting, and sync KDocs
Kimblebee 6d5e6b4
Merge branch 'main' into kim/refactor/quickSettings/button-rows
Kimblebee 8d5e463
Merge branch 'main' into kim/refactor/quickSettings/button-rows
Kimblebee 687f0a1
Address PR comments: refactor Quick Settings layouts, decouple HDR st…
Kimblebee 6799783
spotless
Kimblebee c3e2211
Refactor QuickSettingsController and align HDR constraints
Kimblebee 54dfcf2
Refactor Quick Settings to unified layout and apply code review cleanups
Kimblebee c682cbc
Refactor QuickSettings row components to use a generic list-based…
Kimblebee fa32a0c
use connected button shapes
Kimblebee cb36de9
adjust button dimensions
Kimblebee b58627f
adjustpreview
Kimblebee e7f3631
spotless
Kimblebee 41658c0
Merge branch 'main' into kim/refactor/quickSettings/button-rows
Kimblebee bfd867e
update test behavior and minsdk
Kimblebee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.