docs: fix segment selection in demo notebook - #1088
Open
AKnassa wants to merge 1 commit into
Open
Conversation
`layer.segments` became a `VisibleSegments` view when starred segments were introduced, and that view is a `MutableSet`, which has no `update`. Running the cell raised `AttributeError: 'VisibleSegments' object has no attribute 'update'`. Use `|=`, which `MutableSet` supports and which accepts any iterable, so the cell reads much as before. `update` itself now lives on `StarredSegments`, if starring rather than selecting is wanted. This was the only stale call in the notebook; the later `segments.add` cell is still correct. Fixes google#609
AKnassa
marked this pull request as ready for review
July 30, 2026 05:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #609
What this does
Fixes one broken line in the Jupyter notebook demo.
Why
The "Select a couple segments" cell called
segments.update([...]). That stopped working whenlayer.segmentsbecame a set-like view of the starred segments, so running the cell raisedAttributeError: 'VisibleSegments' object has no attribute 'update'.What changed
segments.update([1752, 88847])becomessegments |= [1752, 88847], which the set view does support and which accepts any iterable.updateitself still exists onStarredSegments, if starring rather than selecting is what is wanted.How to see it
Run the notebook. The cell now selects the two segments instead of raising an error. This was the only stale call in the notebook — the later
segments.addcell is still correct.