You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @dyeddala , please include a vulnerable and safe version both in the same docker compose file, along with a proof of concept (curl command or similar) in the README.md that demonstrates the expected responses for vulnerable and safe versions. There's no need to include instructions to create the docker compose file in the README, only instructions for how to run the vulnerable and safe versions using the docker-compose.yml file that already exists.
When I tested the docker compose file in the README.md file, it resulted in both services being shown as vulnerable, so it looks like it needs tweaking. For the vulnerable version, please use the one closest to the patched version (it might be 1.73.4). I think, but am not sure, that the --rc-no-auth CLI argument is why both are being reported as vulnerable from your plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the PR.