Skip to content

Standardize XProf hostname resolution logic #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

Standardize XProf hostname resolution logic #3555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tsl/profiler/protobuf/profiler_options.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,12 @@ message ProfileOptions {
// under the repository path. If not set, the current timestamp will be used.
string session_id = 14;

// If set, this hostname will be used to name the profile file.
string override_hostname = 15;
// Deprecated: This field is now treated as a boolean toggle. If set
// (non-empty), the profiler ignores its value and uses the system hostname
// (tsl::port::Hostname()) to name the profile file. Otherwise, it falls back
// to request.host_name(). For remote mode, use advanced_configuration with
// key "override_hostnames" (string) instead.
string override_hostname = 15 [deprecated = true];
}

// Options for remote profiler session manager.
Expand Down
Loading