chore: preserve and log full error backtraces in generate-updates - #27556
Open
torreypayne wants to merge 2 commits into
Open
chore: preserve and log full error backtraces in generate-updates#27556torreypayne wants to merge 2 commits into
torreypayne wants to merge 2 commits into
Conversation
torreypayne
marked this pull request as draft
August 5, 2026 20:54
torreypayne
marked this pull request as ready for review
August 6, 2026 18:32
aandreassa
reviewed
Aug 6, 2026
aandreassa
left a comment
Contributor
There was a problem hiding this comment.
Please change it to chore since it doesn't affect clients.
Make sure to double check the commit message before you merge too (since it was originally pushed as a fix commit and that differs from the title).
torreypayne
force-pushed
the
fix/generate-updates-logging
branch
from
August 6, 2026 21:53
da02fc0 to
3d5e146
Compare
aandreassa
approved these changes
Aug 6, 2026
torreypayne
force-pushed
the
fix/generate-updates-logging
branch
from
August 7, 2026 04:33
6fa1b44 to
a13eae5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stack to address b/542740217 (Apiary library generation errors preventing releases)
See bug for artifacts showing validation of the error output
Summary
When
toys generate-updatesencounters an error generating a gem (e.g.bin/generate-apiexits non-zero), the exit code and error backtraces were not captured or printed in the final summary output.Fix
regen_single_gemandclean_old_gemsin.toys/generate-updates.rbto capturestdoutandstderrstream output viaout: [:capture, :inherit], err: [:capture, :inherit].@errors.generate-updates.rbto print full error messages and backtraces for all failed gems.--verbosetobin/generate-apiif Toys verbosity is enabled (verbosity > 0).