Skip to content

fix(storage): fix flaky storage integration tests #13256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nidhiii-27 wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

fix(storage): fix flaky storage integration tests #13256

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
afa3dda
fix(storage): fix flaky storage integration tests
nidhiii-27 May 22, 2026
5ed800c
refactor code
nidhiii-27 May 23, 2026
785c01f
Revert "refactor code"
nidhiii-27 May 25, 2026
9e590dc
add debug logs
nidhiii-27 May 25, 2026
316e698
add try-with-resource blocks
nidhiii-27 May 25, 2026
0f51afa
Merge branch 'main' into storage/flaky-test-fix-2
nidhiii-27 May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions ...le-cloud-storage/src/test/java/com/google/cloud/storage/it/runner/registry/TestBench.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ public void start() {
dockerImage,
"gunicorn",
"--bind=0.0.0.0:9000",
"--worker-class=sync",
"--worker-class=gthread",
"--threads=10",
"--access-logfile=-",
"--keep-alive=0",
Expand Down Expand Up @@ -401,6 +401,15 @@ private void dumpServerLog(String prefix, File out) throws IOException {
}
}

private static int findFreePort() {
try (java.net.ServerSocket socket = new java.net.ServerSocket(0)) {
socket.setReuseAddress(true);
return socket.getLocalPort();
} catch (java.io.IOException e) {
throw new RuntimeException("Failed to find a free port", e);
}
}
Comment thread
nidhiii-27 marked this conversation as resolved.

static Builder newBuilder() {
return new Builder();
}
Expand Down Expand Up @@ -495,13 +504,16 @@ static final class Builder {
private String containerName;

private Builder() {
this(
false,
DEFAULT_BASE_URI,
DEFAULT_GRPC_BASE_URI,
DEFAULT_IMAGE_NAME,
DEFAULT_IMAGE_TAG,
DEFAULT_CONTAINER_NAME);
int httpPort = findFreePort();
int grpcPort = findFreePort();
String uuid = java.util.UUID.randomUUID().toString().substring(0, 8);

this.ignorePullError = false;
this.baseUri = "http://127.0.0.1:" + httpPort;
this.gRPCBaseUri = "http://127.0.0.1:" + grpcPort;
this.dockerImageName = DEFAULT_IMAGE_NAME;
this.dockerImageTag = DEFAULT_IMAGE_TAG;
this.containerName = DEFAULT_CONTAINER_NAME + "_" + uuid;
}
Comment thread
nidhiii-27 marked this conversation as resolved.

private Builder(
Expand Down
Loading