ci: lint Kubernetes manifests with Flint - #1635
Merged
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s lint toolchain to validate Flint’s in-progress kube-linter integration by pinning Flint to a specific upstream git revision, installing kube-linter via Aqua, and wiring in config/exclusions needed to lint the repository’s Kubernetes demo manifest.
Changes:
- Switch Flint installation from the Aqua release to a pinned git revision via
mise(for pre-release feature validation). - Add kube-linter (0.8.3) and introduce a kube-linter config excluding checks that conflict with the dev/demo
k8s/lgtm.yamlmanifest. - Exclude a specific GitHub Actions workflow from Flint runs due to an actionlint version compatibility gap with
environment.deployment.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
mise.toml |
Pins Flint to a git revision and installs kube-linter via Aqua for CI/lint validation. |
.github/renovate-tracked-deps.json |
Keeps Renovate’s tracked-deps snapshot in sync with the updated mise.toml tool list. |
.github/config/kube-linter.yaml |
Configures kube-linter check exclusions appropriate for the repo’s demo Kubernetes manifest. |
.github/config/flint.toml |
Updates Flint config to exclude a workflow file that actionlint can’t currently parse. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "aqua:owenlamont/ryl" = "0.21.0" | ||
| "aqua:stackrox/kube-linter" = "0.8.3" | ||
| biome = "2.5.2" | ||
| "cargo:https://github.com/grafana/flint" = "rev:f68039f" |
…-linter Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> # Conflicts: # .github/renovate-tracked-deps.json # mise.toml
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
.github/config/flint.toml:6
- PR description mentions excluding the release workflow from Flint due to actionlint’s lack of support for environment.deployment, but the config excludes .github/workflows/ghcr-image-build-and-publish.yml. If that’s intentional, consider updating the PR description to avoid confusion; otherwise, update the excluded workflow path.
"**/package-lock.json",
# actionlint 1.7.12 predates GitHub's environment.deployment setting.
".github/workflows/ghcr-image-build-and-publish.yml",
]
mise.toml:6
- PR description says Flint is pinned to an unreleased kube-linter implementation from grafana/flint#437, but this PR doesn’t change the flint pin (mise.toml still has "aqua:grafana/flint" = "0.22.10"). Either add the intended flint pin change to this PR, or update the PR description so it matches what’s actually being changed here.
"aqua:grafana/gcx" = "v0.6.0"
"aqua:grafana/oats" = "0.8.0"
"aqua:stackrox/kube-linter" = "0.8.3"
bats = "1.14.0"
zeitlinger
marked this pull request as ready for review
July 28, 2026 11:44
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
martincostello
previously approved these changes
Jul 28, 2026
zeitlinger
changed the title
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
martincostello
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kube-lintermise entryk8s/lgtm.yamlmanifest using Flint's defaultk8s/discoveryThis adopts the released kube-linter support from Flint v0.22.10 using the standard
aqua:grafana/flintbackend for Flint itself.Testing
mise exec -- flint run --full kube-lintermise run lint:fixmise run lintmise run test:unit(38 tests)