-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add safe dotenv linting #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # `dotenv-linter` | ||
|
|
||
| <!-- linter-metadata-start --> | ||
| <!-- Generated. Run `mise run generate` to regenerate. --> | ||
|
|
||
| | | | | ||
| | -------- | --------------------------------------------------------------- | | ||
| | Project | [dotenv-linter](https://github.com/dotenv-linter/dotenv-linter) | | ||
| | Fix | yes | | ||
| | Binary | `dotenv-linter` | | ||
| | Scope | [files](../linters.md#scope-files) | | ||
| | Patterns | `.env .env.* *.env` | | ||
|
|
||
| <!-- linter-metadata-end --> | ||
|
|
||
| `dotenv-linter` checks and safely formats dotenv environment files without | ||
| printing their values. | ||
|
|
||
| Flint checks only explicit `.env`-style files: `.env`, `.env.*`, and files | ||
| ending in `.env`. It passes those file paths rather than a directory, so | ||
| unrelated YAML, Compose, and application configuration files are never scanned. | ||
|
|
||
| Both check and fix mode disable dotenv-linter's update check, avoiding | ||
| unexpected network access. Fix mode also uses `--no-backup`, so it does not | ||
| leave secret-bearing backup files behind: | ||
|
|
||
| ```bash | ||
| flint run --fix dotenv-linter | ||
| ``` | ||
|
|
||
| The fixer is serialized with other Flint formatters that may own the same file. | ||
| Do not commit secret-bearing `.env` files. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| bad line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [tools] | ||
| "dotenv-linter" = "4.0.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| [expected] | ||
| args = "run --full --fix dotenv-linter" | ||
| exit = 1 | ||
| stderr = ''' | ||
| flint: fixed: dotenv-linter — commit before pushing | ||
| ''' | ||
|
|
||
| [expected.files] | ||
| ".env" = "PORT=8080\n" | ||
|
|
||
| [fake_bins] | ||
| dotenv-linter = ''' | ||
| #!/bin/sh | ||
| set -eu | ||
| case "$1" in | ||
| check) exit 1 ;; | ||
| fix) printf 'PORT=8080\n' > .env ;; | ||
| *) exit 1 ;; | ||
| esac | ||
| ''' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| NAME=flint | ||
| PORT=8080 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| [tools] | ||
| "dotenv-linter" = "4.0.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [expected] | ||
| args = "run --full dotenv-linter" | ||
| exit = 0 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.