Skip to content

Run the test suite on Windows in CI - #110

Open
yemine0x01 wants to merge 5 commits into
gridfm:mainfrom
yemine0x01:add-windows-ci
Open

yemine0x01 wants to merge 5 commits into
gridfm:mainfrom
yemine0x01:add-windows-ci

Conversation

@yemine0x01

Copy link
Copy Markdown
Collaborator

Depends on #108 and #109. Their commits are included here until they merge.

Signed-off-by: yemine0x01 <youssouf.emine@artelys.com>
Signed-off-by: yemine0x01 <youssouf.emine@artelys.com>
Signed-off-by: yemine0x01 <youssouf.emine@artelys.com>
@romeokienzler

Copy link
Copy Markdown
Collaborator

@yemine0x01 Thanks for this — it's a clean, well-scoped change: the _julia_string escaping (backslashes/quotes/$) is exactly right for Windows paths, it carries a Google-style docstring + type hint, and the new test_correct_network.py covers the tricky cases (quoted dirs, $HOME) with a real round-trip.

What's needed

No docstring/type-hint/print gaps on my read, and no new deps or config params, so the pyproject.toml/YAML/docs steps look N/A here. Deferring the merge call to a maintainer.

— 🤖 _automated pre-review; a maintainer will follow up_

@romeokienzler

Copy link
Copy Markdown
Collaborator

@yemine0x01 Thanks for pulling in main — the branch is now current (mergeStateStatus went from needing a rebase to UNSTABLE, i.e. just waiting on checks), so that point is cleared.

Quick status on the rest:

Nothing in the merge introduced new issues on my read. Deferring the merge call to a maintainer.

— 🤖 _automated pre-review; a maintainer will follow up_

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants