-
Notifications
You must be signed in to change notification settings - Fork 6
Emit notif references #4175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
souissimai
wants to merge
19
commits into
main
Choose a base branch
from
emit-notif-references
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Emit notif references #4175
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e7c7ce7
actions , ref modif
586f8aa
Merge branch 'main' into reference-modification-actions
souissimai 5261c3d
Merge branch 'main' into reference-modification-actions
souissimai 58ea185
Merge branch 'main' into reference-modification-actions
Mathieu-Deharbe ada0d8e
Merge branch 'main' into reference-modification-actions
souissimai 5998069
Merge branch 'main' into reference-modification-actions
souissimai 911c229
remarks
fe29e1d
move copy a reference
b26084f
move copy a reference
e3fba5f
breaking changes
0e638b5
resolve conflicts
e2e1ea4
comments clean
3b96b8c
reception shared element notification
b75e0cd
Merge branch 'main' into emit-notif-references
souissimai 134f866
Merge branch 'main' into emit-notif-references
souissimai 512c694
Merge branch 'main' into emit-notif-references
souissimai 1eba0f9
clean
aa2b027
Merge branch 'main' into emit-notif-references
souissimai 103d902
Merge branch 'main' into emit-notif-references
souissimai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,6 +41,7 @@ export enum NotificationType { | |
| // Modifications | ||
| MODIFICATIONS_UPDATE_FINISHED = 'UPDATE_FINISHED', | ||
| MODIFICATIONS_DELETE_FINISHED = 'DELETE_FINISHED', | ||
| SHARED_ELEMENT_UPDATE = 'sharedElementUpdate', | ||
| // Events | ||
| EVENT_CRUD_FINISHED = 'EVENT_CRUD_FINISHED', | ||
|
|
||
|
|
@@ -279,6 +280,12 @@ interface ModificationsDeleteFinishedEventDataHeaders extends CommonStudyEventDa | |
| nodes: UUID[]; | ||
| } | ||
|
|
||
| interface SharedElementUpdateEventDataHeaders extends CommonStudyEventDataHeaders { | ||
| updateType: NotificationType.SHARED_ELEMENT_UPDATE; | ||
| parentNode: UUID; | ||
| networkModificationUuids?: UUID[]; | ||
| } | ||
|
|
||
| interface EventCrudFinishedEventDataHeaders extends CommonStudyEventDataHeaders { | ||
| updateType: NotificationType.EVENT_CRUD_FINISHED; | ||
| parentNode: UUID; | ||
|
|
@@ -484,6 +491,11 @@ export interface ModificationsUpdateFinishedEventData extends CommonStudyEventDa | |
| payload: undefined; | ||
| } | ||
|
|
||
| export interface SharedElementUpdateEventData extends CommonStudyEventData { | ||
| headers: SharedElementUpdateEventDataHeaders; | ||
| payload: undefined; | ||
| } | ||
|
|
||
| export interface ModificationsDeleteFinishedEventData extends CommonStudyEventData { | ||
| headers: ModificationsDeleteFinishedEventDataHeaders; | ||
| payload: undefined; | ||
|
|
@@ -674,6 +686,10 @@ export function isModificationsDeleteFinishedNotification( | |
| return notif.headers?.updateType === NotificationType.MODIFICATIONS_DELETE_FINISHED; | ||
| } | ||
|
|
||
| export function isSharedElementUpdateNotification(notif: CommonStudyEventData): notif is SharedElementUpdateEventData { | ||
| return notif.headers?.updateType === NotificationType.SHARED_ELEMENT_UPDATE; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not a notification from study server !
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The notification is emitted by study‑server, not directory‑server |
||
| } | ||
|
|
||
| export function isIndexationStatusNotification(notif: CommonStudyEventData): notif is IndexationStatusEventData { | ||
| return notif.headers?.updateType === NotificationType.INDEXATION_STATUS; | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UPDATE_SHARED_ELEMENT ?