Use the limit sets tabular modification from commons-ui

[achour94]

PR Summary

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a80ae0c2-70df-4016-a618-a947769032b9

📥 Commits

Reviewing files that changed from the base of the PR and between f5071bf and 5b956cd.

📒 Files selected for processing (10)

• src/components/app-wrapper.jsx
• src/components/dialogs/network-modifications/limit-sets/limit-sets-modification-dialog.tsx
• src/components/dialogs/network-modifications/limit-sets/limit-sets-tabular-modification-form.tsx
• src/components/dialogs/network-modifications/limit-sets/limit-sets-tabular-modification-utils.ts
• src/components/utils/field-constants.ts
• src/translations/dynamic/csv-locale-en.ts
• src/translations/dynamic/csv-locale-fr.ts
• src/translations/messages-en.ts
• src/translations/messages-fr.ts
• src/utils/translationKeys.ts

💤 Files with no reviewable changes (9)

• src/translations/dynamic/csv-locale-en.ts
• src/translations/messages-en.ts
• src/utils/translationKeys.ts
• src/components/dialogs/network-modifications/limit-sets/limit-sets-tabular-modification-form.tsx
• src/translations/dynamic/csv-locale-fr.ts
• src/components/app-wrapper.jsx
• src/components/utils/field-constants.ts
• src/translations/messages-fr.ts
• src/components/dialogs/network-modifications/limit-sets/limit-sets-tabular-modification-utils.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The limit-set modification dialog now uses shared @gridsuite/commons-ui form utilities and DTO conversion. The local form, conversion utilities, obsolete constants, CSV locale modules, and related translations are removed.

Changes

Limit-set modification migration

Layer / File(s)	Summary
Adopt shared form utilities src/components/dialogs/network-modifications/limit-sets/limit-sets-modification-dialog.tsx	The dialog uses shared form types, schema, defaults, DTO conversion, and submission values.
Remove local form implementation src/components/dialogs/network-modifications/limit-sets/limit-sets-tabular-modification-form.tsx, src/components/dialogs/network-modifications/limit-sets/limit-sets-tabular-modification-utils.ts, src/components/utils/field-constants.ts	The local form, conversion utilities, and obsolete field constants are deleted.
Remove legacy translation resources src/components/app-wrapper.jsx, src/translations/dynamic/*, src/translations/messages-*.ts, src/utils/translationKeys.ts	The CSV locale modules, related message entries, imports, bundle entries, and unused translation key are removed.

Suggested reviewers: dbraquart

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to ad29b

The migration uses the shared limit-set form utilities while preserving the modification submission contract. No actionable current-head risk remains.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The description contains only a template and does not explain the migration or its impact. It is too vague to assess as a meaningful change description.	Add a concise summary stating that the limit sets tabular modification form and related utilities were migrated from local code to commons-ui, and that obsolete local translations and constants were removed.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the main change: migrating the limit sets tabular modification form to commons-ui.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}