Skip to content

Visual node with shared modifications - #4255

Open
souissimai wants to merge 4 commits into
mainfrom
visual-node-with-shared-modifications
Open

souissimai wants to merge 4 commits into
mainfrom
visual-node-with-shared-modifications

Conversation

@souissimai

Copy link
Copy Markdown
Contributor

PR Summary

SOUISSI Maissa (Externe) added 2 commits October 16, 2026 10:54
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0324ba15-16d0-41bf-9dfe-2c648682b293
📥 Commits

Reviewing files that changed from the base of the PR and between 1a14836 and 940e7c4.

📒 Files selected for processing: 2
  • src/translations/messages-en.ts
  • src/translations/messages-fr.ts
🚧 Files skipped from review as they are similar to previous changes: 2
  • src/translations/messages-fr.ts
  • src/translations/messages-en.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The tree now refreshes parent nodes after modification updates and deletes. Graph node data carries the shared-modification flag, which controls a tooltip label and double outline.

Changes: Shared modification indicator

Layer / File(s) Summary
Refresh parent nodes after modification events
src/types/notification-types.ts, src/components/network-modification-tree-pane-event-handlers.ts
The tree update event union includes modification update and delete completion events. Their handlers fetch and dispatch the updated parent node.
Carry the shared-modification flag into graph data
src/components/graph/tree-node.type.ts, src/components/graph/util/model-functions.ts, src/components/graph/network-modification-tree-model.ts
Node data types and model conversion include the shared-modification flag. Tree model updates retain it for non-root nodes.
Show shared modifications on graph nodes
src/components/graph/nodes/network-modification-node.tsx, src/translations/messages-en.ts, src/translations/messages-fr.ts
Nodes with the flag show a tooltip label and a double outline. English and French catalogs provide the label.

Sequence Diagram(s)

sequenceDiagram
  participant ModificationEvent
  participant handleTreeModelUpdate
  participant NetworkModificationTreeModel
  participant NetworkModificationNode
  ModificationEvent->>handleTreeModelUpdate: Modification update or delete finishes
  handleTreeModelUpdate->>NetworkModificationTreeModel: Fetch and dispatch updated parent node
  NetworkModificationTreeModel->>NetworkModificationNode: Pass hasReferencedModifications in node data
  NetworkModificationNode->>NetworkModificationNode: Show tooltip label and double outline when flag is true
Loading

Suggested reviewers: flomillot

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 940e7

This change adds a tooltip label in English and French for shared modifications. No merge-blocking risk was identified in the reviewed changes.

Pre-merge checks: Passed 3 · Failed 1 · Inconclusive 1

Failed Failed checks: 1 warning · 1 inconclusive

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 8 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check Inconclusive The description contains only a template and does not provide meaningful details about the changeset. Add a concise summary of the node-data changes, shared-modification visualization, event handling, translations, and validation performed.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: visualizing nodes that contain shared modifications.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant