Skip to content

feat: add network existance check before applying modification - #886

Merged
etiennehomer merged 13 commits into
mainfrom
feat/check-network-existance
Sep 9, 2026
Merged

feat: add network existance check before applying modification#886
etiennehomer merged 13 commits into
mainfrom
feat/check-network-existance

Conversation

@GhilesA

@GhilesA GhilesA commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

PR Summary

For unloaded studies, we do not apply modification if we can't find the network.
this may be temporary before the refactore of the create+apply modification endpoint.

this may be temporary before the refactore of the create+apply
modification endpoint
@GhilesA
GhilesA requested a review from etiennehomer September 4, 2026 09:27
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c3853601-bf6e-4212-94c7-2ace43b80dae


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread pom.xml
<artifactId>powsybl-network-store-client</artifactId>
<!-- FIXME remove this in the next powsybl release update -->
<version>${network-store-client.version}</version>
</dependency>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to override the iidm-impl version.
We usually override the version of the 3 network-store artefacts

Suggested change
</dependency>
</dependency>
<!-- FIXME: to be removed at next release of gridsuite-dependencies or powsybl-ws-dependencies -->
<dependency>
<groupId>com.powsybl</groupId>
<artifactId>powsybl-network-store-iidm-impl</artifactId>
<version>${network-store.version}</version>
</dependency>
<!-- FIXME: to be removed at next release of gridsuite-dependencies or powsybl-ws-dependencies -->
<dependency>
<groupId>com.powsybl</groupId>
<artifactId>powsybl-network-store-model</artifactId>
<version>${network-store.version}</version>
</dependency>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
@sonarqubecloud

sonarqubecloud Bot commented Sep 9, 2026

Copy link
Copy Markdown

@etiennehomer
etiennehomer merged commit ce74695 into main Sep 9, 2026
4 checks passed
@etiennehomer
etiennehomer deleted the feat/check-network-existance branch September 9, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants