Follow up CodeRabbit remarks from computation API extraction

[coderabbitai]

Summary

Track the CodeRabbit review remarks that are intentionally out of scope for pull request #1028. This pull request only moves code into dedicated controllers and services.

Requested by: @basseche

Required changes

1. Delegate sensitivity-analysis factor-count handling from SensitivityAnalysisController to SensitivityAnalysisService. Move network UUID and variant ID resolution into the service.

   • File: src/main/java/org/gridsuite/study/server/controller/sensitivityanalysis/SensitivityAnalysisController.java
   • Review comment: Refactor study controller to create controllers and services for each computation calculation #1028 (comment)

2. Add download response headers to the short-circuit CSV export endpoint.

   • File: src/main/java/org/gridsuite/study/server/controller/shortcircuit/ShortCircuitController.java
   • Review comment: Refactor study controller to create controllers and services for each computation calculation #1028 (comment)

3. Preserve the documented response behavior for state-estimation parameter reset. Confirm the service return type and map the reset-with-user-profile result to HTTP 204 where applicable.

   • File: src/main/java/org/gridsuite/study/server/controller/stateestimation/StateEstimationParametersController.java
   • Review comment: Refactor study controller to create controllers and services for each computation calculation #1028 (comment)

4. Prevent local and remote load-flow result state divergence when transactional updates fail.

   • File: src/main/java/org/gridsuite/study/server/service/loadflow/LoadFlowService.java
   • Review comment: Refactor study controller to create controllers and services for each computation calculation #1028 (comment)

5. Replace the PCC-min-specific parameter create/update flow with the shared AbstractComputationService.setComputationParameters flow, while preserving invalidation and notifications.

   • File: src/main/java/org/gridsuite/study/server/service/pccmin/PccMinService.java
   • Review comment: Refactor study controller to create controllers and services for each computation calculation #1028 (comment)

6. Correct the voltage-init stop endpoint OpenAPI summary.

   • File: src/main/java/org/gridsuite/study/server/controller/voltageinit/VoltageInitController.java
   • Review comment: Refactor study controller to create controllers and services for each computation calculation #1028 (comment)

7. Add the resultUuid header to the sensitivity-analysis failure-message test fixture, matching the production message contract.

   • File: src/test/java/org/gridsuite/study/server/SensitivityAnalysisTest.java
   • Review comment: Refactor study controller to create controllers and services for each computation calculation #1028 (comment)

Acceptance criteria

• Each item above is verified against the current code before implementation.
• The implementation preserves existing API contracts unless the item explicitly changes the contract.
• Relevant tests cover the modified behavior.
• Pull request Refactor study controller to create controllers and services for each computation calculation #1028 remains limited to the controller and service extraction.

Source pull request

#1028