Change checkNetworkExistence endpoint's body to include network load status - #1082
Merged
Conversation
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ghazwarhili
reviewed
Sep 7, 2026
|
|
||
| public RootNetworkLoadStatus getRootNetworkLoadStatus(UUID networkUuid) { | ||
| Optional<RootNetworkEntity> rootNetworkEntity = getRootNetwork(networkUuid); | ||
| return rootNetworkEntity.map(RootNetworkEntity::getLoadStatus).orElse(null); |
Contributor
There was a problem hiding this comment.
why Optional here (else null) ? (the default value is LOADED)
Contributor
Author
There was a problem hiding this comment.
but if networkEntity does not exist are you sure we should return Loaded ?
ghazwarhili
reviewed
Sep 8, 2026
| @@ -0,0 +1,4 @@ | |||
| package org.gridsuite.study.server.dto; | |||
|
|
|||
ghazwarhili
approved these changes
Sep 8, 2026
Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com> Signed-off-by: basseche <bassel.el-cheikh_externe@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
In order to differentiate, when network does not exist in store, between loaded and unloaded network
we change the endpoint checkNetworkExistence., to add the information on root network load status.