Skip to content

Migrate iidm-excluded-extensions - #1090

Merged
etiennehomer merged 1 commit into
mainfrom
migrate-iidm-excluded-extensions
Sep 11, 2026
Merged

Migrate iidm-excluded-extensions#1090
etiennehomer merged 1 commit into
mainfrom
migrate-iidm-excluded-extensions

Conversation

@etiennehomer

Copy link
Copy Markdown
Contributor

PR Summary

To be able to reload UNLOADED studies, "[]" values for excluded-extensions should be migrated to "null" values

Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d4b927d4-f523-496b-91cf-d2e87b1960ab

📥 Commits

Reviewing files that changed from the base of the PR and between 202acef and 5e40fc7.

📒 Files selected for processing (2)
  • src/main/resources/db/changelog/changesets/changelog_20260910T140041Z.xml
  • src/main/resources/db/changelog/db.changelog-master.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Adds a Liquibase changeset that updates iidm.die.excluded-extensions from '[]' to 'null', and registers the changeset in the master changelog.

Changes

Import parameter migration

Layer / File(s) Summary
Migration and changelog registration
src/main/resources/db/changelog/changesets/changelog_20260910T140041Z.xml, src/main/resources/db/changelog/db.changelog-master.yaml
The new changeset updates matching import_parameters rows. The master changelog includes the new changeset with relative file resolution enabled.

Suggested reviewers: ayolab

Merge Risk: 🟡 Moderate · up to 5e40f

This migration changes the excluded-extensions parameter representation; if the stored form is not what the reload path expects, UNLOADED studies may remain unreloadable. Confirm the required null representation before merging.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the migration of iidm-excluded-extensions, which is the main change in the pull request.
Description check ✅ Passed The description explains that the pull request changes "[]" values to null values to enable reloading of UNLOADED studies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@etiennehomer
etiennehomer merged commit 45e3e7a into main Sep 11, 2026
5 checks passed
@etiennehomer
etiennehomer deleted the migrate-iidm-excluded-extensions branch September 11, 2026 07:48
Meklo pushed a commit that referenced this pull request Sep 11, 2026
Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants