Skip to content

Fix the comment on what a composite applicability update reaches - #1102

Merged
flomillot merged 4 commits into
mainfrom
feat/independent-composite-activation
Oct 2, 2026
Merged

flomillot merged 4 commits into
mainfrom
feat/independent-composite-activation

Conversation

@flomillot

@flomillot flomillot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

The network modification server no longer propagates the change to the modifications it holds, so the comment saying otherwise becomes wrong. No functional change.

Goes with gridsuite/network-modification-server#899.

The network modification server no longer propagates the change to the sub modifications of the composite:
each one carries an applicability of its own.

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3bdac909-3621-4fe3-82de-a75898a81a80

📥 Commits

Reviewing files that changed from the base of the PR and between a0dd9e6 and 2f05a27.

📒 Files selected for processing (1)
  • src/test/java/org/gridsuite/study/server/NetworkModificationTest.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/test/java/org/gridsuite/study/server/NetworkModificationTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates a test comment. The comment now states that root-network applicability is updated for the composite alone.

Changes

Reference activation test

Layer / File(s) Summary
Applicability behavior comment
src/test/java/org/gridsuite/study/server/NetworkModificationTest.java
The comment describes the root-network applicability update as applying to the composite alone.

Suggested reviewers: ghazwarhili

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 2f05a

This change only updates a comment in a test and does not alter runtime behavior. It is safe to merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the comment update about the scope of composite applicability changes.
Description check ✅ Passed The description accurately explains the comment-only change and its reason. It matches the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…osite-activation

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
…osite-activation

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
@sonarqubecloud

sonarqubecloud Bot commented Oct 2, 2026

Copy link
Copy Markdown

@flomillot
flomillot merged commit b4a9c54 into main Oct 2, 2026
5 checks passed
@flomillot
flomillot deleted the feat/independent-composite-activation branch October 2, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants