Skip to content

use targetQ values from OpenAC to generate battery modifications - #160

Open
Mathieu-Deharbe wants to merge 4 commits into
mainfrom
batteries-voltage-init
Open

use targetQ values from OpenAC to generate battery modifications#160
Mathieu-Deharbe wants to merge 4 commits into
mainfrom
batteries-voltage-init

Conversation

@Mathieu-Deharbe

Copy link
Copy Markdown
Contributor

Get data from openReac, transforms it a little bit and send to :
gridsuite/network-modification-server#883
gridsuite/network-modification#227

Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 64c6835c-7c3e-4103-8855-c86cea975dea

📥 Commits

Reviewing files that changed from the base of the PR and between 3b2f3b3 and 6c1432e.

📒 Files selected for processing (4)
  • src/main/java/org/gridsuite/voltageinit/server/dto/BatteryModificationInfos.java
  • src/main/java/org/gridsuite/voltageinit/server/dto/VoltageInitModificationInfos.java
  • src/main/java/org/gridsuite/voltageinit/server/service/NetworkModificationService.java
  • src/test/java/org/gridsuite/voltageinit/server/VoltageInitControllerTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@Mathieu-Deharbe Mathieu-Deharbe self-assigned this Sep 7, 2026
Mathieu-Deharbe and others added 2 commits September 8, 2026 14:48
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

.add();
bat.newExtension(VoltageRegulationAdder.class)
.withTargetV(215.)
.withVoltageRegulatorOn(false)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a test for .withVoltageRegulatorOn(true) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants