Repository navigation
feat(server): run playground subscriptions over SSE on SSE-only servers - #111
Merged
Merged
Conversation
The playground always subscribed over WebSocket, so a server registering only sse.New() had no working subscriptions in GraphiQL. Pick graphql-sse when the SSE transport is registered without the WebSocket one; WebSocket remains the default in every other case.
examples/sse registers sse.New() as the only subscription transport and shows a self-terminating countdown stream plus pub/sub notifications.
…gistered transports Drop the playgroundSSE field and inspect the server's transport chains when the playground is served instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled playground now subscribes over SSE when
sse.New()is registered without a WebSocket transport. WebSocket stays the default otherwise.Tested in the browser against SSE-only servers (shared and separate subscription paths) and the WebSocket subscriptions example.