Improve incremental tracking of method references and lambdas - #10323
Open
niloc132 wants to merge 15 commits into
Open
Improve incremental tracking of method references and lambdas#10323niloc132 wants to merge 15 commits into
niloc132 wants to merge 15 commits into
Conversation
niloc132
commented
May 27, 2026
Comment on lines
+1035
to
+1037
| if (incrementalCompile) { | ||
| compilerContext.getMinimalRebuildCache().recordNestedTypeNamesPerType(unit, types); | ||
| } |
Member
Author
There was a problem hiding this comment.
This change lets us only deserialize the set of GWT types once. This is the only call to CompilationUnit.getTypes() and also the only call to recordNestedTypeNamesPerType.
niloc132
commented
Jun 10, 2026
| recordNestedTypeName(compilationUnitTypeName, typeName); | ||
| } | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
THis pair of loops could probably be more efficient if we didn't remove-all and add-all, but just looked for the actual added/removed changes. GWT UI classes tend to have lambdas, anon inner classes, so this usually isn't a very short list, but it probably isn't long enough to really matter - but its also pretty likely most of the classes that were present last time are still there.
vegegoku
reviewed
Jul 9, 2026
vegegoku
reviewed
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that all GWT JDeclaredTypes are correctly marked as changed, including method references and lambdas.
Changes naming convention for method reference types - this slightly degrades debugability, but better ensures that fresh compiles and incremental compiles will result in the same output for a given class, improving how much testing we can do.
Note that adding/removing inner classes results in different incremental/initial output, so one of the new tests must opt out of that check.
Fixes #9670