normalize module base path before resolving rpc policy resource - #10357
Open
Samin061 wants to merge 2 commits into
Open
normalize module base path before resolving rpc policy resource#10357Samin061 wants to merge 2 commits into
Samin061 wants to merge 2 commits into
Conversation
zbynek
reviewed
Jul 2, 2026
zbynek
reviewed
Jul 2, 2026
Author
|
gentle ping |
vjay82
pushed a commit
to vjay82/gwt
that referenced
this pull request
Jul 21, 2026
Cherry-pick of upstream gwtproject/gwt PR gwtproject#10357. Normalize the client-supplied module base URL with URI.normalize() before the containment check so that ../ traversal segments cannot escape the module directory when locating .gwt.rpc/symbol-map resources. Upstream-PR: gwtproject#10357
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServerSerializationStreamReader validates the strong name before policy lookup, but the module base URL from the same request reaches loadSerializationPolicy untouched, where new URL(moduleBaseURL).getPath() is joined with the strong name and the .gwt.rpc suffix and opened through getResourceAsStream. A value such as http://host/ctx/../../WEB-INF/foo still satisfies the startsWith(contextPath) guard, so the ../ segments survive into the resource path and can point the policy load outside the module directory; getRequestModuleBasePath resolves the symbol-map path the same way. Normalize the path with URI.normalize() before the containment check at both call sites so traversal segments collapse and the existing check rejects anything that leaves the module directory.