[Contractors] Add admin UI#14322
Open
manuthecoder wants to merge 22 commits into
Open
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+310
to
+315
| make_item( | ||
| name: "Payments", | ||
| path: employee_payments_admin_index_path, | ||
| count: ->{ Employee::Payment.paid.count }, | ||
| name: "Contractor Payments", | ||
| path: admin_payments_path, | ||
| count: ->{ Payment.under_review.count }, | ||
| count_type: :tasks | ||
| ), |
Member
There was a problem hiding this comment.
I would move payments to be under the Spending tab with the other transfer types
| ) | ||
| end | ||
|
|
||
| def legacy_payroll_items |
Member
There was a problem hiding this comment.
Go ahead and get rid of this - we're not using these old pages again
| <div class="flex flex-col sm:flex-row items-center gap-2"> | ||
| <%= render "events/filters/search", form: %> | ||
| <%= form.select :entity_type, [%w[Person person], %w[Business business]], { include_blank: "All types", selected: @entity_type } %> | ||
| <%= form.select :filter, [%w[Managed managed], %w[Archived archived]], { include_blank: "All entities", selected: params[:filter] } %> |
Member
There was a problem hiding this comment.
It might make more sense to have these be individual checkboxes instead of a single select - maybe you want to see archived managed LEs
| </article> | ||
|
|
||
| <% if @position.under_review? %> | ||
| <% admin_tool("mt-4 flex items-center justify-between") do %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds admin UI