Skip to content

[Payout Settings] Trigger update when payout settings are saved even if unchanged #14337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Luke-Oldenburg merged 2 commits into from
Jul 20, 2026
+9 −11
Merged

[Payout Settings] Trigger update when payout settings are saved even if unchanged #14337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38a143c
[Payout] Trigger update when payout settings are saved even if unchanged
Mohamad-Mortada Jul 17, 2026
55de1e9
Merge branch 'main' into mo-payout-allow-updating-unchanged
YodaLightsabr Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions app/javascript/controllers/payout_methods_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ export default class extends Controller {
this.closeAll()
$(row.querySelector('[data-payout-methods-panel]')).slideDown(200)
row.querySelector('[data-pm-actions]').classList.add('is-editing')
const form = row.querySelector('[data-payout-methods-panel] form')
if (form) form.dataset.pmSnapshot = this.serialize(form)
}

cancelRow(event) {
Expand All @@ -40,10 +38,6 @@ export default class extends Controller {
const row = event.currentTarget.closest('[data-payout-methods-row]')
const form = row.querySelector('[data-payout-methods-panel] form')
if (!form) return
if (form.dataset.pmSnapshot === this.serialize(form)) {
this.cancelRow(event)
return
}
form.requestSubmit()
}

Expand Down Expand Up @@ -73,8 +67,4 @@ export default class extends Controller {
.closest('[data-payout-methods-row]')
?.querySelector('[data-pm-actions]')
}

serialize(form) {
return new URLSearchParams(new FormData(form)).toString()
}
}
10 changes: 9 additions & 1 deletion app/services/legal_entity/payout_method_service/update.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,18 @@ def error_messages
def build_payout_method
details_class = LegalEntity::PayoutMethod.details_class_for(@details_type)
pm = LegalEntity::PayoutMethod.new(legal_entity: @legal_entity, default: @make_default)
pm.details = details_class.new(@details_attrs) if details_class
pm.details = details_class.new(preserved_ach_attrs || @details_attrs) if details_class
pm
end

def preserved_ach_attrs
old = @replacing&.details
return unless old.is_a?(LegalEntity::PayoutMethod::AchTransfer)
return unless [@details_attrs[:account_number], @details_attrs[:routing_number]].none? { _1.to_s.match?(/\A\d+\z/) }

@details_attrs.to_h.merge(account_number: old.account_number, routing_number: old.routing_number)
end

def apply_business_rules
if @payout_method.details.nil?
@payout_method.errors.add(:base, "is invalid. Please choose another method.")
Expand Down