Skip to content

[Disbursement] Use Ledger::Item to find CTs and CPTs #14361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Luke-Oldenburg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Disbursement] Use Ledger::Item to find CTs and CPTs #14361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions app/models/disbursement/incoming.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,12 @@ def counterparty
alias_method :counterparty_subledger, :source_subledger
alias_method :transaction_category, :destination_transaction_category

# These need to be updated later to not use HCB code
def canonical_transactions
@canonical_transactions ||= CanonicalTransaction.where(hcb_code: incoming_hcb_code)
@canonical_transactions ||= CanonicalTransaction.where(ledger_item: Ledger::Item.find_by(linked_object: self))
end

def canonical_pending_transactions
@canonical_pending_transactions ||= ::CanonicalPendingTransaction.where(hcb_code: incoming_hcb_code)
@canonical_pending_transactions ||= ::CanonicalPendingTransaction.where(ledger_item: Ledger::Item.find_by(linked_object: self))
end

end
Expand Down
5 changes: 2 additions & 3 deletions app/models/disbursement/outgoing.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,12 @@ def counterparty
alias_method :counterparty_subledger, :destination_subledger
alias_method :transaction_category, :source_transaction_category

# These need to be updated later to not use HCB code
def canonical_transactions
@canonical_transactions ||= CanonicalTransaction.where(hcb_code: outgoing_hcb_code)
@canonical_transactions ||= CanonicalTransaction.where(ledger_item: Ledger::Item.find_by(linked_object: self))
end

def canonical_pending_transactions
@canonical_pending_transactions ||= ::CanonicalPendingTransaction.where(hcb_code: outgoing_hcb_code)
@canonical_pending_transactions ||= ::CanonicalPendingTransaction.where(ledger_item: Ledger::Item.find_by(linked_object: self))
end

end
Expand Down
Loading