Skip to content

[Ledger::Item] Remove type_metadata #14363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garyhtou merged 3 commits into from
Jul 20, 2026
+38 −23
Merged

[Ledger::Item] Remove type_metadata #14363

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f3d819
[Ledger::Item] Remove `type_metadata`
Luke-Oldenburg Jul 19, 2026
b90827d
Merge branch 'main' into lro-remove-type-metadata-li
Luke-Oldenburg Jul 20, 2026
9fd80e9
Apply suggestion from @Luke-Oldenburg
Luke-Oldenburg Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 38 additions & 23 deletions app/models/ledger/item.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,44 @@ def map!
end

def humanized_type
type_metadata.first
case linked_object_type
when "Invoice"
"Invoice"
when "Donation"
"Donation"
when "AchTransfer"
"Outgoing ACH"
when "Wire"
"Wire"
when "PaypalTransfer"
"PayPal transfer"
when "WiseTransfer"
"Wise transfer"
when "Check"
"Mailed check"
when "IncreaseCheck"
"Mailed check"
when "CheckDeposit"
"Check deposit"
when "Disbursement::Outgoing"
"Outgoing transfer"
when "Disbursement::Incoming"
"Incoming transfer"
when "StripeServiceFee"
"Stripe service fee"
when "BankFee"
"Fiscal sponsorship fee"
when "FeeRevenue"
"Fee revenue"
when "Reimbursement::PayoutHolding"
"Reimbursement payout holding"
when "Reimbursement::ExpensePayout"
"Reimbursement"
when "CardCharge"
"Card charge"
Comment thread
Luke-Oldenburg marked this conversation as resolved.
else
"Bank account transaction"
end
end

def icon
Expand Down Expand Up @@ -425,28 +462,6 @@ def assign_linked_object!
update!(linked_object:) if linked_object.present?
end

def type_metadata
{
"Disbursement::Incoming": ["Incoming transfer", "door-enter"],
"Disbursement::Outgoing": ["Outgoing transfer", "door-leave"],
"Reimbursement::ExpensePayout": ["Reimbursement", "reimbursement"],
"Reimbursement::PayoutHolding": ["Reimbursement payout holding", "reimbursement"],
"AchTransfer": ["Outgoing ACH", "payment-transfer"],
"BankFee": ["Fiscal sponsorship fee", "bank-icon"],
"Check": ["Mailed check", "email"],
"IncreaseCheck": ["Mailed check", "email"],
"CheckDeposit": ["Check deposit", "cheque"],
"Donation": ["Donation", "support"],
"FeeRevenue": ["Fee revenue", "bank-icon"],
"Invoice": ["Invoice", "payment-docs"],
"PaypalTransfer": ["PayPal transfer", "paypal"],
"Wire": ["Wire", "web"],
"WiseTransfer": ["Wise transfer", "wise"],
"StripeServiceFee": ["Stripe service fee", "cash"],
"CardCharge": ["Card charge", "card"]
}[linked_object_type&.to_sym] || ["Bank account transaction", "cash"]
end

end

end