Add DB-backed test coverage and run Postgres tests in CI

.env.ci

@@ -1,6 +1,6 @@
+DATABASE_URL=postgresql://postgres:password@localhost:5432/hackerspub
 MODE=development
 ORIGIN=http://localhost/
-DATABASE_URL=postgresql://localhost/hackerspub
 KV_URL=file:///tmp/kv.db
 SECRET_KEY=SecretKeyForUnitTests
 INSTANCE_ACTOR_KEY='{"kty":"RSA","alg":"RS256","n":"2fG1bUonD7dhunje36058uoNxW_CKREX1pd-63mRoYo-4XbLCyLqTbqy1ar-gdYNqd8OUhqjYXLvjRtS36N3DBb8zhIHmNvMFCMCVaX2hBp_kZhwBPch9Nk2g84rukVSOzjARaN6BhotlvJJ8RfHbTQHJnTIrgRZ5h9nifBfwjfCkS0S3plJfXzHo4XjlF5oTHRfvjM1sOGvsC4G9jZXgLP4MVgOZi3ry3NoYIhtnczk3lt7NWMtr37NK9jxXItXgo9juy-R88C8NPgq6wtuWr_fbMoERyq6wNG05MofnDAgk73PDid47fNkIueybgbFo8dJo68IcgMF8TiDeASp7sOl8TTpxlwOUtbtIGDB8FQDblVw16K7VAOD-ZEng0L_bmeDKf8VZ3WtH95QeBe_2JVPNecuut3NkHy4quWt6g4AujG08pDHWQUwT8ivyqsbBjxRAlqf1_8mcn_1EHnjuC_kuNYZ-lN9IuPk40hChbQpU8kLPTe0nx0JOSvTLumJT0ElDG0WJTOMJnB85B6Q68IiqTXMsKK3dWJWlstZ2Q6CHhAnxd1OyedS3Uq0fcynaePvD2AaA18fuxnTpM4XeFrLxuZ9DjuNLbIdkZMGQxB-o76eefHR1BTuz_sulFAL6Tapvn-P92A2XuGgL6x104MlLTpyOg9z3isFQOjsKTc","e":"AQAB","d":"W7APJnpCsp7wc1V0Vd93eJU00_HvWf2B7NpxH7lWJgKV755dT0MSFT9NCwzT42Vc_DEFwk7Imy-STefH1qPbam-lTUBSh-E4GuSbj9KxQeQv9N2Pitc5JtvWzl6HEOcm8Bkw8lsS88xBj7ZAmzfowy1XMLuCzYqxE1n04hgJARkaNp8iyBjuzOcYydeC5aFN-ZQfz1GV7eMUWWcTsLMt3sxXxtKHxD7fawkTSUE79F4FjvInhE9EIgeTYzXyXH-Wgiu2xkH-AfD8fMBGtflqJK2B3i-i2xnD1Wij1HigEcJBgkYg_JBolJqHbxPQge9BaGRnu3_gaq6Q6mlfDbfQkQZflNn0fCcp49D6YIcGD_1swObr8XDX7rgjSS5WmzMRQbNZsL6qCMohi0h65zcZk9ZUfnwX7vLKWjKTUfpF2uZqUOn_q1DsLMBDCu4ayFQPxA4C2GDlnR4stVFaWRtjNTNmiYWf7nO3H8PgoJHYpQt-vdn0i946INGiceJK5hhFkyiidh1ZJHgfPumOJeEDxBLlmOwaWHsqmplh5yq5RSCN1qpOqzGOJOop_RrHrZ5h9rRR1A4IQOFUE-8ivo8Mg4e6eLNDbLSSsQvRfgv47rbH5cP8LOzY4q9J3Kupl5a7df3Ar7FyyOAR3-QyzXajWLyiy0CJw4k1HtasCK6yBsE","p":"55S8olIxe8x8tu7DK0TpnDi-3bAR3jcetuZX4oSaTE_xu8kpl_TqALuecmswYHQA3IZ2i9rR0uIJHyeQuvHp0lTNhs-fwxIlnJTLXLZmNcwIVe5z2CMaL80WEBFIEG_6J4KNtt13Mg8h56Ij5d7Ry0NpVYEQCDege291LPN7x_cKf8jbdsRRFVckv9nZz8kQ6Prhn3kALV-PAxCum_sl07iz-YNZn0gRnYhP8pWddahdtUQeo_mCH__eHmIJAmpJsxufLgPXH9v0btuXhLz4P5pRO533wpmzE0t7U9pisPnMdi9NIssHyM0p6fEhPd87YBq8VMjkgYhXukYY0ah5YQ","q":"8Ozcf5BUMJnU6Ov5kQ2Ap6W1g_Ig_JOWonAkDHlHo0ElEcHRmkC5SeA7PCsbaEqGVq8Oqi6x90UaODedy-qSzjKx5i0FLKmDjb_4B4fLVFrUST6cQQu7bPcvWRRP2NyAN1AZrt0Y_uSbhIHFVOouHoMqVfQj0aTDK-sp1lPmPn9g7wch8y3Lc9iqcIgn43wy67XJtP5AYdplJrs4JuXYrZtbsfXsRdA2PO6mcazetIBVMETkuKIGF7gEGTI_8JpM23Y_ykM7XFwEhx4ecJtKw0-1e57w-8pt-nlfIbRNQDkJwKX-w6J5z6J6VgFAWp4jvSG15qoC5gU51xHkm_Exlw","dp":"V_jor8EJiz3jIpsRCR7kn7PuzchVAVVvFYvrVuGIu_Sin_OLGW6wdhbP2idd-UYYDa4G2poFm1bCoFMnZ9z-NiiA6vV0e2YpY5IirtWbflRD1mD_INw01nPSLchi19ux69BshUscPKgC-Tte57P9fnndSd39eSGolTuCB9F29D-kfWaP-E4bfz_bdgYL-CMpiVfE3g_ZQWNLsJ5ltltxwzwnImIDab628mEV_dFYP5n1_yYhfakLBZzthB05zvERjjiv_4r17eRgtrw0kvg2VfMJaNxZglNg87N45iHP2-sJANx3MQBvtJg7k-NF_XsP0zJU2OB37b0dlmWKiBq4AQ","dq":"BDSeRLvIPHDy_n3gBWAu9r41xO_dE4uf_YXnmzAix_7DHuQ7PG4Uze1UG2DFQbTLU4gKwX2_LYnPQ1v1LTITDfZklJgElxr-aOMI-Vite_N58S1enOQPiX9nHC72ldqDgnOrfxns7cYf0NhTEYBk_bNccdOpLGer4IBiYpNkWYLvtjxxo0URYBxQHVbDG313hhXOR5KInSyqx1pNSKCKf71OhHS-gxl3WOjxjtptqMj0s7sAIxjw8kkMCUSPSSvoW4xc4LL7vkj86z7jWSPc0jv59wZ3Pm3yLYUg2_3Bu3VDblF3eQLFDZLQf9_Vt7868Ho-KqCdHFbLA64UR4SWUQ","qi":"u1riaXXLRX6mnhMPbnxOBZDUbjqDv5Sq-4WawFWDQuiZvEn_Vp52tgVV7Ra9-kEM4CHTLdo2MZfLizjAXyDMrSWuDw8G_cVy8G75mg7c41s-TUSC-7ioqzbVvOkMDuZ_KoNqDLiDos3GT8XFXxVQcscU37Qo31L4usE2Y3mmlZfpm_GqGGh4rwkiWxjXrr5VtypehFZFRf_mbY8dLBJW-wF2f1uisUp8xh_s9cG2PPnzVO8Gi0V4Od2fK3OTky4SCp-mRqvbll94DCrFyS07P9_35K2k64wgKNVeg57n-1ByNPRQS5NjKbtMVUHX0Qnk2YawD3gQXb2IFhX4S8Gvzg","key_ops":["sign"],"ext":true}'

.github/workflows/main.yml

@@ -10,6 +10,20 @@ on:
 jobs:
   test:
     runs-on: ubuntu-latest
+    services:
+      postgres:
+        image: postgres:16
+        env:
+          POSTGRES_USER: postgres
+          POSTGRES_PASSWORD: password
+          POSTGRES_DB: hackerspub
+        ports:
+        - 5432:5432
+        options: >-
+          --health-cmd "pg_isready -U postgres -d hackerspub"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
     steps:
     - uses: actions/checkout@v4
     - uses: denoland/setup-deno@v2
@@ -28,6 +42,8 @@ jobs:
     - name: Build web-next
       run: pnpm build
       working-directory: web-next
+    - name: Run database migrations
+      run: npx @dotenvx/dotenvx run -f .env.ci -- deno task migrate
     - name: Run tests
       if: always()
       run: npx @dotenvx/dotenvx run -f .env.ci -- deno task test

graphql/account.test.ts

@@ -0,0 +1,285 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+import { encodeGlobalID } from "@pothos/plugin-relay";
+import * as vocab from "@fedify/vocab";
+import { execute, parse } from "graphql";
+import { updateAccountData } from "@hackerspub/models/account";
+import { schema } from "./mod.ts";
+import {
+  createFedCtx,
+  insertAccountWithActor,
+  makeGuestContext,
+  makeUserContext,
+  toPlainJson,
+  withRollback,
+} from "../test/postgres.ts";
+
+const viewerQuery = parse(`
+  query Viewer {
+    viewer {
+      username
+      name
+      handle
+    }
+  }
+`);
+
+const accountByUsernameQuery = parse(`
+  query AccountByUsername($username: String!) {
+    accountByUsername(username: $username) {
+      username
+      name
+      handle
+    }
+  }
+`);
+
+const invitationTreeQuery = parse(`
+  query InvitationTree {
+    invitationTree {
+      id
+      username
+      name
+      avatarUrl
+      inviterId
+      hidden
+    }
+  }
+`);
+
+const updateAccountMutation = parse(`
+  mutation UpdateAccount($input: UpdateAccountInput!) {
+    updateAccount(input: $input) {
+      account {
+        username
+        bio
+        locales
+        preferAiSummary
+        defaultNoteVisibility
+        defaultShareVisibility
+      }
+    }
+  }
+`);
+
+test("viewer returns the signed-in account and null for guests", async () => {
+  await withRollback(async (tx) => {
+    const account = await insertAccountWithActor(tx, {
+      username: "viewerquery",
+      name: "Viewer Query",
+      email: "viewerquery@example.com",
+    });
+
+    const signedInResult = await execute({
+      schema,
+      document: viewerQuery,
+      contextValue: makeUserContext(tx, account.account),
+      onError: "NO_PROPAGATE",
+    });
+
+    assert.equal(signedInResult.errors, undefined);
+    assert.deepEqual(
+      toPlainJson(signedInResult.data),
+      {
+        viewer: {
+          username: "viewerquery",
+          name: "Viewer Query",
+          handle: "@viewerquery@localhost",
+        },
+      },
+    );
+
+    const guestResult = await execute({
+      schema,
+      document: viewerQuery,
+      contextValue: makeGuestContext(tx),
+      onError: "NO_PROPAGATE",
+    });
+
+    assert.equal(guestResult.errors, undefined);
+    assert.deepEqual(toPlainJson(guestResult.data), { viewer: null });
+  });
+});
+
+test("accountByUsername returns a local account by username", async () => {
+  await withRollback(async (tx) => {
+    const account = await insertAccountWithActor(tx, {
+      username: "lookupgraphql",
+      name: "Lookup GraphQL",
+      email: "lookupgraphql@example.com",
+    });
+
+    const result = await execute({
+      schema,
+      document: accountByUsernameQuery,
+      variableValues: { username: account.account.username },
+      contextValue: makeGuestContext(tx),
+      onError: "NO_PROPAGATE",
+    });
+
+    assert.equal(result.errors, undefined);
+    assert.deepEqual(toPlainJson(result.data), {
+      accountByUsername: {
+        username: "lookupgraphql",
+        name: "Lookup GraphQL",
+        handle: "@lookupgraphql@localhost",
+      },
+    });
+  });
+});
+
+test("invitationTree redacts hidden accounts", async () => {
+  await withRollback(async (tx) => {
+    const visible = await insertAccountWithActor(tx, {
+      username: "visibletree",
+      name: "Visible Tree",
+      email: "visibletree@example.com",
+    });
+    const hidden = await insertAccountWithActor(tx, {
+      username: "hiddentree",
+      name: "Hidden Tree",
+      email: "hiddentree@example.com",
+    });
+
+    const updated = await updateAccountData(tx, {
+      id: hidden.account.id,
+      hideFromInvitationTree: true,
+    });
+    assert.ok(updated != null);
+
+    const result = await execute({
+      schema,
+      document: invitationTreeQuery,
+      contextValue: makeGuestContext(tx),
+      onError: "NO_PROPAGATE",
+    });
+
+    assert.equal(result.errors, undefined);
+
+    const nodes = (result.data as {
+      invitationTree: Array<{
+        id: string;
+        username: string | null;
+        name: string | null;
+        avatarUrl: string;
+        inviterId: string | null;
+        hidden: boolean;
+      }>;
+    }).invitationTree;
+    const visibleNode = nodes.find((node) => node.id === visible.account.id);
+    const hiddenNode = nodes.find((node) => node.id === hidden.account.id);
+
+    assert.ok(visibleNode != null);
+    assert.ok(hiddenNode != null);
+    assert.equal(visibleNode.hidden, false);
+    assert.equal(visibleNode.username, "visibletree");
+    assert.equal(visibleNode.name, "Visible Tree");
+
+    assert.equal(hiddenNode.hidden, true);
+    assert.equal(hiddenNode.username, null);
+    assert.equal(hiddenNode.name, null);
+    assert.equal(
+      hiddenNode.avatarUrl,
+      "https://gravatar.com/avatar/?d=mp&s=128",
+    );
+  });
+});
+
+test("updateAccount updates profile preferences for the signed-in account", async () => {
+  await withRollback(async (tx) => {
+    const account = await insertAccountWithActor(tx, {
+      username: "updateaccountgraphql",
+      name: "Update Account GraphQL",
+      email: "updateaccountgraphql@example.com",
+    });
+
+    const fedCtx = createFedCtx(tx);
+    fedCtx.getActor = (identifier: string) =>
+      Promise.resolve(
+        new vocab.Person({
+          id: fedCtx.getActorUri(identifier),
+        }),
+      );
+
+    const result = await execute({
+      schema,
+      document: updateAccountMutation,
+      variableValues: {
+        input: {
+          id: encodeGlobalID("Account", account.account.id),
+          bio: "Updated profile bio",
+          locales: ["ko-KR", "en-US"],
+          preferAiSummary: true,
+          hideFromInvitationTree: true,
+          hideForeignLanguages: true,
+          defaultNoteVisibility: "FOLLOWERS",
+          defaultShareVisibility: "UNLISTED",
+        },
+      },
+      contextValue: makeUserContext(tx, account.account, { fedCtx }),
+      onError: "NO_PROPAGATE",
+    });
+
+    assert.equal(result.errors, undefined);
+    assert.deepEqual(toPlainJson(result.data), {
+      updateAccount: {
+        account: {
+          username: "updateaccountgraphql",
+          bio: "Updated profile bio",
+          locales: ["ko-KR", "en-US"],
+          preferAiSummary: true,
+          defaultNoteVisibility: "FOLLOWERS",
+          defaultShareVisibility: "UNLISTED",
+        },
+      },
+    });
+
+    const stored = await tx.query.accountTable.findFirst({
+      where: { id: account.account.id },
+    });
+    assert.ok(stored != null);
+    assert.equal(stored.hideFromInvitationTree, true);
+    assert.equal(stored.hideForeignLanguages, true);
+    assert.deepEqual(stored.locales, ["ko-KR", "en-US"]);
+    assert.equal(stored.preferAiSummary, true);
+    assert.equal(stored.noteVisibility, "followers");
+    assert.equal(stored.shareVisibility, "unlisted");
+  });
+});
+
+test("updateAccount rejects a second username change", async () => {
+  await withRollback(async (tx) => {
+    const account = await insertAccountWithActor(tx, {
+      username: "renameonce",
+      name: "Rename Once",
+      email: "renameonce@example.com",
+    });
+
+    const renamed = await updateAccountData(tx, {
+      id: account.account.id,
+      username: "renamedonce",
+    });
+    assert.ok(renamed != null);
+    assert.ok(renamed.usernameChanged != null);
+
+    const result = await execute({
+      schema,
+      document: updateAccountMutation,
+      variableValues: {
+        input: {
+          id: encodeGlobalID("Account", account.account.id),
+          username: "renamedtwice",
+        },
+      },
+      contextValue: makeUserContext(tx, { ...account.account, ...renamed }),
+      onError: "NO_PROPAGATE",
+    });
+
+    assert.deepEqual(toPlainJson(result.data), { updateAccount: null });
+    assert.equal(result.errors?.length, 1);
+    assert.equal(
+      result.errors?.[0].message,
+      "Username cannot be changed after it has been changed.",
+    );
+  });
+});