fix: replace deprecated 'aborted' event with 'close' on IncomingMessage#4579
Open
sapirbaruch wants to merge 2 commits into
Open
fix: replace deprecated 'aborted' event with 'close' on IncomingMessage#4579sapirbaruch wants to merge 2 commits into
sapirbaruch wants to merge 2 commits into
Conversation
Contributor
|
@sapirbaruch Can you please add tests for this? |
Adds a test verifying that request.active() returns false when the client closes the connection before a response is sent. The test uses Net.connect so it works regardless of hostname resolution, and polls active() directly without relying on the 'disconnect' event. Covers the Node.js v24+ path where IncomingMessage 'aborted' is gone.
Author
|
Added a regression test in The test uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
'aborted'event onhttp.IncomingMessagewas deprecated in Node.js v17 and no longer fires in v24+. As a result,Request.active()always returnstruebecause_eventContext.requestis never set tonullon client disconnects.The fix replaces
req.on('aborted', ...)withreq.on('close', ...)and guards the abort logic with ares.writableEndedcheck — the same guard used by the existingres.on('close')handler — to distinguish a premature client disconnect from a normal connection teardown.Fixes #4575.