Add utility to find the start of a capture - #1054
Open
JoeyLemur wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds ld-find-start, a CLI that scans an RF capture for sustained, advancing CAV/CLV VBI frame numbers and outputs a validated ld-decode --start N argument for the preceding clean pre-roll. It includes guarded handling for uncertain VBI-less captures, packaging integration, and unit tests.
Motivation
Rather than repeated guessing of where the start of the disc content is and reading through ld-decode errors, I wanted a command to automatically find the start.
Related Issues
This works under v7.2.1, but not under main 8af0932 -- see issue #1053
Changes Made
Added the ld-find-start command-line tool.
Testing
python3 -m pytest -q— 25 passed.python3 -m pytest -q tests/test_start_finder.py— 12 passed.python3 -m isort --check-only and python3 -m py_compilefor the new code.python3 ld-find-start --helpandpython3 -m lddecode.start_finder --version.The unit tests cover CAV/CLV detection, rejected non-sequential addresses, decoder failures, clean pre-roll recovery, guarded fallback behavior, and CLI exit/output behavior.