fix: sort merged secret keys alphabetically for deterministic env var order - #232
Open
ravisingal wants to merge 1 commit into
Open
fix: sort merged secret keys alphabetically for deterministic env var order#232ravisingal wants to merge 1 commit into
ravisingal wants to merge 1 commit into
Conversation
… order harnesscommon.renderSecretsAsEnvironmentVariables merged keys from three Sprig maps via `keys`, whose iteration order is randomized per render. This produced a different env var order on every helm template/upgrade even with unchanged values, causing spurious manifest diffs. Sorting the merged keys alphabetically makes the output deterministic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
harnesscommon.renderSecretsAsEnvironmentVariables merged keys from three Sprig maps via
keys, whose iteration order is randomized per render. This produced a different env var order on every helm template/upgrade even with unchanged values, causing spurious manifest diffs. Sorting the merged keys alphabetically makes the output deterministic.