Dependency resolved and slight performance enhancements#12
Open
saadz-khan wants to merge 11 commits intoharvardnlp:masterfrom
Open
Dependency resolved and slight performance enhancements#12saadz-khan wants to merge 11 commits intoharvardnlp:masterfrom
saadz-khan wants to merge 11 commits intoharvardnlp:masterfrom
Conversation
added 11 commits
August 28, 2021 18:26
- This caused huge errors in form of tracebacks. - Now all depencies are resolved. - Removed duplicate dependencies between requirements.txt file - Preprocessing works fine so the project is good to go.
- All dependencies along with the python version mentioned. - Dataset used and preprocessing steps mentioned. - Config file alteration mentioned.
- Changed GPU ranks so that CPU is used by default. - Uncomment the gpu-ranks and according to the number of GPU's being used. Set world_size (1 for 1 GPU or CPU).
- Defaulting to CPU rather then to GPU. - Comment out the gpu_ranks variable in config and set world_size. (world_size 1 for 1 GPU or CPU)
- Here adding +2 to any n_feats will crash our results.
- .bin file creation from raw stories - .bin to .txt.src and .txt.tgt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issues with its current version:
requirements.txtThis PR covers:
requirements.txtwith all the proper versions so that code does not break if packages are updated in the future.raw cnn-dm storiesto .txt.src and .txt.tgt