Skip to content

BE-525: HashQL: Remove implicit type-widening from Integer operations, and make comparison size aware #8693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
indietyp wants to merge 4 commits into
base: bm/be-515-hashql-remove-offset-0-materialization-fence-from-generated
Choose a base branch
from

fix: suggestions from review

9fcabac
Select commit
Loading
Failed to load commit list.
Open

BE-525: HashQL: Remove implicit type-widening from Integer operations, and make comparison size aware #8693

fix: suggestions from review
9fcabac
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 26, 2026 in 1s

59.12% (+0.17%) compared to ed78af0

View this Pull Request on Codecov

59.12% (+0.17%) compared to ed78af0

Details

Codecov Report

❌ Patch coverage is 89.24051% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.12%. Comparing base (ed78af0) to head (9fcabac).

Files with missing lines Patch % Lines
...hashql/mir/src/pass/transform/inst_simplify/mod.rs 45.83% 4 Missing and 9 partials ⚠️
libs/@local/hashql/mir/src/interpret/value/mod.rs 83.33% 1 Missing and 2 partials ⚠️
libs/@local/hashql/mir/src/interpret/error.rs 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@                                            Coverage Diff                                            @@
##           bm/be-515-hashql-remove-offset-0-materialization-fence-from-generated    #8693      +/-   ##
=========================================================================================================
+ Coverage                                                                  58.94%   59.12%   +0.17%     
=========================================================================================================
  Files                                                                       1340     1342       +2     
  Lines                                                                     128866   129518     +652     
  Branches                                                                    5814     5852      +38     
=========================================================================================================
+ Hits                                                                       75966    76572     +606     
- Misses                                                                     52005    52043      +38     
- Partials                                                                     895      903       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov