Skip to content

BE-525: HashQL: Remove implicit type-widening from Integer operations, and make comparison size aware #8693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
indietyp wants to merge 4 commits into
base: bm/be-515-hashql-remove-offset-0-materialization-fence-from-generated
Choose a base branch
from

fix: suggestions from review

7533415
Select commit
Loading
Failed to load commit list.
Open

BE-525: HashQL: Remove implicit type-widening from Integer operations, and make comparison size aware #8693

fix: suggestions from review
7533415
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 27, 2026 in 0s

59.13% (+0.09%) compared to 42733cd

View this Pull Request on Codecov

59.13% (+0.09%) compared to 42733cd

Details

Codecov Report

❌ Patch coverage is 89.24051% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.13%. Comparing base (42733cd) to head (7533415).

Files with missing lines Patch % Lines
...hashql/mir/src/pass/transform/inst_simplify/mod.rs 45.83% 4 Missing and 9 partials ⚠️
libs/@local/hashql/mir/src/interpret/value/mod.rs 83.33% 1 Missing and 2 partials ⚠️
libs/@local/hashql/mir/src/interpret/error.rs 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@                                            Coverage Diff                                            @@
##           bm/be-515-hashql-remove-offset-0-materialization-fence-from-generated    #8693      +/-   ##
=========================================================================================================
+ Coverage                                                                  59.03%   59.13%   +0.09%     
=========================================================================================================
  Files                                                                       1341     1343       +2     
  Lines                                                                     129373   129719     +346     
  Branches                                                                    5828     5857      +29     
=========================================================================================================
+ Hits                                                                       76377    76703     +326     
- Misses                                                                     52099    52113      +14     
- Partials                                                                     897      903       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov