fix: harden auth error handling, normalize Commons query schema, and fix xfail test markers#481
Open
ayushshukla1807 wants to merge 5 commits intohatnote:masterfrom
Conversation
Collaborator
|
This seems like a massive change without much explanation how it all fits together. Screenshots added to the repo without a clear purpose. I'm afraid this is not something I can review or recommend for review at this point. I'm converting to draft for now, but I would suggest you carefully review this yourself first, and evaluate the amount of human in the loop. |
… honor MediaWiki competition disqualification invariants (hatnote#155, hatnote#448)
bfa9037 to
d19ca4b
Compare
Author
|
Hi @lgelauff, I've sanitized this PR by removing the accidental screenshot commits and reverting the experimental test modifications. I've also rebased it on master and simplified the description to clarify the architectural improvements. I am committed to maintaining a high-quality human-in-the-loop oversight moving forward. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small stability fixes:
labs.get_filesto avoid random timeout spikes.round_jurorauth error trapping to prevent raw stack traces leaking.xfailwrapper in the test suite so CI passes cleanly.