Skip to content

fix(backend): prevent silent discarding of SQLAlchemy filters in get_campaign_rounds (#399) #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayushshukla1807 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(backend): prevent silent discarding of SQLAlchemy filters in get_campaign_rounds (#399) #500

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5e0549
fix(dao): prevent silent discarding of SQLAlchemy filters in get_camp…
Apr 15, 2026
af95219
test(dao): add isolated unit tests for campaign round filtering and o…
Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions montage/rdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,8 +1138,8 @@ def from_round(cls, user_dao, round_id):
def get_campaign_rounds(self, campaign, with_cancelled=False):
q = self.query(Round).filter_by(campaign=campaign)
if not with_cancelled:
q.filter(Round.status != CANCELLED_STATUS)
q.order_by(Round.create_date)
q = q.filter(Round.status != CANCELLED_STATUS)
q = q.order_by(Round.create_date)
return q.all()

def get_active_jurors(self, round_id):
Expand Down