fix(ui): enforce threshold selection for ranking rounds to prevent 500 error (#383)#501
Open
ayushshukla1807 wants to merge 1 commit intohatnote:masterfrom
Conversation
Author
|
Just simulated this exact bug locally ( With this patch, Ran the frontend build and basic tests too: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #383.
If a ranking round was submitted without a threshold,
threshold: nullwas being sent to the API. Since the backend expects an int/float, this silently crashed the request with a 500 error.I added a quick check in
RoundNew.vueto trap this locally and trigger the standard form validation alert (alertService.error) instead, avoiding the network crash entirely.