Skip to content

Increase default download interval and backoff #357

Description

@okafke

I am seeing more and more timeouts when downloading assets, perhaps Mojang has changed some rate limits.
Similar observations have also been observed by other users: headlesshq/mc-runtime-test#82

The default values for these properties should get increased.

Property<Long> ASSETS_DELAY = number("hmc.assets.delay");
Property<Long> ASSETS_RETRIES = number("hmc.assets.retries");
Property<Boolean> ASSETS_PARALLEL = bool("hmc.assets.parallel");
Property<Boolean> DUMMY_ASSETS = bool("hmc.assets.dummy");
Property<Boolean> ASSETS_CHECK_HASH = bool("hmc.assets.check.hash");
Property<Boolean> ASSETS_CHECK_SIZE = bool("hmc.assets.check.size"); // < implied by check hash
Property<Boolean> ASSETS_CHECK_FILE_HASH = bool("hmc.assets.check.file.hash");
Property<Boolean> ASSETS_BACKOFF = bool("hmc.assets.backoff");
Property<Boolean> ALWAYS_DOWNLOAD_ASSETS_INDEX = bool("hmc.always.download.assets.index");

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions