fix(schema): reject interpolated cwd placeholders#65
Merged
Conversation
28a7e6e to
d5dbda7
Compare
2 tasks
Merged
heggria
added a commit
that referenced
this pull request
Jul 9, 2026
Release prep for 0.1.8 — a small patch release shipping the cwd interpolation-placeholder fix (#65) plus the batched dependency bumps (#57, #66). No engine API changes. Bumps all seven packages + root to 0.1.8 in lockstep, including the taskflow-core / taskflow-hosts / taskflow-mcp-core dependency pins and the codex/claude/opencode plugin manifests (.mcp.json npx pins + plugin.json versions), and adds the 0.1.8 CHANGELOG section. Pre-flight: typecheck 0 errors, 1160/1160 unit tests green, build + 7 packages OK, skills drift-guard green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject interpolation placeholders in
phase.cwdduring schema validation.cwdis documented as a literal path (or a reserved workspace keyword liketemp,dedicated,worktree), but flows could still pass values like{args.repo_dir}. At runtime this eventually surfaced as a misleadingspawn ... node ENOENT, which looked like a missing Node binary even though the real problem was an invalid working directory.This change fails fast with a clear validation error instead.
Changes
phase.cwdschema.test.tsExample
Before:
{ "name": "x", "phases": [ { "id": "p", "type": "agent", "task": "t", "cwd": "{args.repo_dir}" } ] }Could pass validation and later fail with:
After:
Testing
PI_TASKFLOW_BUILTIN_AGENTS_DIR= node --conditions=development --experimental-strip-types --test packages/taskflow-core/test/schema.test.tspnpm --filter taskflow-core buildpnpm --filter pi-taskflow build