Upgrade dependencies and switch from alga to simba - #10
Conversation
hmeyer
left a comment
hmeyer
left a comment
There was a problem hiding this comment.
Thank you!
Please also bump to minor version of this package to 0.9.
| once_cell = "1.4" | ||
| bbox = "0.11" | ||
| num-traits = "0.2" | ||
| bbox = "0.11.2" |
There was a problem hiding this comment.
Wouldn't just major+minor be fine?
There was a problem hiding this comment.
I'm using the default conventions of the cargo-edit tool which was what I used to automate this change. I suppose it might help ensure that users of this crate get at least the version of a dependency that was used to run the test suite. Imagine if 0.5.2 is buggy, 0.5.3 is fine, and the tests of this crate were tested against 0.5.3. Setting the patch version ensures that users don't accidentally get the 0.5.2 version (ie. they get at least the version that this crate was tested against).
|
Build currently fails with this PR. Can you please take a look? |
2 participants
The
algacrate is deprecated and has been replaced bysimba. This PR also allows the introduction of a much newernalgebraversion which is pretty significant.Depends on hmeyer/bbox#3 and hmeyer/implicit3d#2 for now, after which the
[patch]section will be removed