Skip to content

Remove padding from item containers - #240

Open
itaikta wants to merge 1 commit into
hoaphantn7604:masterfrom
itaikta:remove-padding-from-item-containers
Open

Remove padding from item containers#240
itaikta wants to merge 1 commit into
hoaphantn7604:masterfrom
itaikta:remove-padding-from-item-containers

Conversation

@itaikta

@itaikta itaikta commented Dec 22, 2023

Copy link
Copy Markdown

This instead can be set in the style given to the itemContainerStyle (it doesn't seem to override for me)
It may also be worth checking to see other values in the hard coded styles that the module user can't change

@vbuongiovanni

Copy link
Copy Markdown

Can we get this approved and merged?? It would be a welcomed changed, given the fact that it would allow the height of the item container to be modified.

@programmrz

Copy link
Copy Markdown

While this would work, I'd suggest merging both the supplied style & the default one, to allow for an "overwrite"?

@programmrz

Copy link
Copy Markdown

any update on this?

@carlos3g

Copy link
Copy Markdown

@itaikta — handled this differently in the maintained fork @carlos3g/element-dropdown (v2.13.0): the default item padding stays for back-compat, but it's now overridable via itemContainerStyle. Closes #322 / #251 / #266 / #250 / #203 / #187 functionally without breaking existing layouts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants