nginx_proxy: Provide option to add configuration parameters to root level of generated nginx conf#4629
nginx_proxy: Provide option to add configuration parameters to root level of generated nginx conf#4629emcauliffe wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Hi @emcauliffe
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
📝 WalkthroughWalkthroughThis PR adds a new ChangesRoot configuration customization
Estimated code review effort: 🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers:
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@nginx_proxy/config.yaml`:
- Line 27: The schema is missing the new options.customize.root_conf property,
causing validation to reject or ignore the setting; update the schema.customize
definition to include a root_conf entry (string or pattern as used by
nginx_root_conf*.conf) so options.customize.root_conf is declared and validated,
and ensure the schema field name matches "root_conf" and its type/constraints
mirror how root_conf is used elsewhere (e.g., string with glob pattern or
regex).
In `@nginx_proxy/DOCS.md`:
- Line 67: The docs currently reference a non-existent option name
`root_blocks`; update the text to use the implemented option
`customize.root_conf` instead so it matches config and code. Specifically,
change the sentence that lists `default`, `servers`, and `root_blocks` to list
`default`, `servers`, and `customize.root_conf` (and if helpful, add a brief
note that this option lives under the `customize` namespace). Ensure any other
occurrences of `root_blocks` in DOCS.md are replaced with `customize.root_conf`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 499037de-3de3-4b26-a232-df79e7ef7204
📒 Files selected for processing (3)
nginx_proxy/DOCS.mdnginx_proxy/config.yamlnginx_proxy/rootfs/etc/nginx/nginx.conf.gtpl
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@nginx_proxy/DOCS.md`:
- Line 67: Update the sentence to reference the fully qualified configuration
keys instead of the generic word "variables": mention `customize.default`,
`customize.servers`, and `customize.root_conf` explicitly so the docs match the
configuration contract and remove ambiguity.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b0cecac0-c7f1-48c8-a053-d2b9c534b963
📒 Files selected for processing (1)
nginx_proxy/DOCS.md
Adding a
root_confparameter underoptions.customizewhich allows for including a file at the root level of the generated nginx conf. This allows support for features like using NGINX in layer 4 with thestreamblock.Summary by CodeRabbit
New Features
Documentation